Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable rust #5

Closed
explosion-mental opened this issue Jan 11, 2024 · 3 comments
Closed

Stable rust #5

explosion-mental opened this issue Jan 11, 2024 · 3 comments

Comments

@explosion-mental
Copy link

packet_simd only works on stable (and I think portable_simd is it's replacement), so while [that stabilizes](https://github.com/rust-lang/rfcs/pull/2366] I propose having a feature flag for stable rust, either by using another crate or disabling simd all together.

@seijikun
Copy link
Owner

kmeans was created with SIMD as a design decision to the core, because everything else I tried at the time (including Matlab, a nalgebra implementation, ...) was too slow.
Making it build with stable would mean implementing everything a second time and maintaining it alongside.
Since I'm not using the library myself anymore, I'm afraid that's not in-scope for me. Sorry.
I admit that the naming kmeans might have been rather unfortunate (since too generic).

@explosion-mental
Copy link
Author

I understand, thanks for the work being done.

@explosion-mental explosion-mental closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
@cyypherus
Copy link

If nothing else, it may be useful to document the requirement for unstable rust 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants