Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Time labels color based on rarity #201

Open
FrozenSocket opened this issue Sep 15, 2016 · 11 comments
Open

[Request] Time labels color based on rarity #201

FrozenSocket opened this issue Sep 15, 2016 · 11 comments

Comments

@FrozenSocket
Copy link
Contributor

This would be a further great addition to @Trustmania labels update.

The really great thing here is the rarity could be personalized to the location been scanned not just some pecking order decided by a person in another country where the spawn rarity is completely different.

We have a list of everything that's spawned in our range and that could be used to decide the local rarity.

@FrozenSocket FrozenSocket changed the title Time labels color based on rarity [Request] Time labels color based on rarity Sep 15, 2016
@Trustmania
Copy link
Collaborator

Hi @FrozenSocket,
i see. the question is, how it will be for the overview. Actually i like it, that i can see on one view which pokemon are there and which are hidden.

What do you think, could it be a option, to have the left border in different colors?

Actually i'm sitting on a different story (will be a supriese ^^).
I think @seikur0 is as well busy with new features.

Do you know, what i like? If the comunity deliver idears to bring the whole thing forward...

@darkforcesjedi
Copy link
Contributor

You can replace the image in webres/static/icons/ with whatever you want. I use assets ripped from Pokemon Go with labels added. You could edit the image to add something to your desired pokemon to make them stand out.

@FrozenSocket
Copy link
Contributor Author

Started working on a little bit of code to address this today, just wanted to give a heads up incase someone was already working on it; please let me know.

@Trustmania
Copy link
Collaborator

me not... so feel free :-)

@Trustmania
Copy link
Collaborator

Can you pls. post a few screenshots if you have something?

@darkforcesjedi
Copy link
Contributor

I would suggest implementing into the filter (instead of on/off, it could be high priority/low priority/off).

@seikur0
Copy link
Owner

seikur0 commented Sep 18, 2016

The filter can get these something like presets, which you could freely name and put in the settings file. The pokesite.py would pass these settings on as ajax call. But that's something separate from the time labels.

I like the idea of color coding the border based on rarity (settings can be passed from the settings file as well, but for now, just put them into the html and I'll move it later, if you want.) And I'd like to keep that separate from the filter, because these are two different things.

@FrozenSocket
Copy link
Contributor Author

I'm thinking of something a little more dynamic to the individual but totally agree the coloring is a separate issue to the spawn filter as far as the work I plan is going anyway.

@darkforcesjedi
Copy link
Contributor

I was talking about the filter on the web front end, not the spawn filter that pokesite.py uses. Separately implementing an importance setting per Pokémon kind of makes the filter redundant. Right now the filter popup toggles between 2 visual styles when you tap on a Pokémon name. There is no reason you couldn't define 3 or more visual styles and cycle through them. You could even add some options to the top of the list to toggle display of the different "importance" groups. You could even add an option to only display Pokémon within a certain distance of your position. So then the user could choose the "high importance" or "red" (whatever you want to call it) setting for Dragonite and the "medium importance" or "yellow" setting for Dragonair and a "low/normal importance" setting for Dratini and "no importance" for Pidgey to hide it all from the same interface.

Depending on the setting, a style could be applied, not just to the time label, but to the marker as well.

@darkforcesjedi
Copy link
Contributor

If that isn't sufficient then maybe I don't understand what you are referring to.

@FrozenSocket
Copy link
Contributor Author

Totally agree with everything your saying @darkforcesjedi ; my view is that the rarity of a pokemon to the individual does not change day to day (yes over time maybe but let's ignore that). Either a pokemon is spawning a lot or a little this doesn't/shouldn't change because I choose a certain web filter. But there could be overlap as you've said letting people filter on certain rarity levels/percentages maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants