-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCP Keep-Alive carrying data #1594
Comments
I forgot to mention that all the TCP Keep-Alive packets I've observed in my environment carry one byte of data at 0x00. |
It sounds like an edge case. I don't know if it is general enough to modify the TcpReassembly. I also wonder if it's a bug of TcpReassembly. In this case, perhaps you may want to handle the packets yourself. |
Everyone who encounters this situation with PcapPlusPlus could benefit if it was handled within PcapPlusPlus. I see herethat it is possible to filter out such packets using the bpf filtering rule, but not when using dpdk Using bpf filtering rules |
@gyl30 is there a pcap file you can share that includes this phenomenon? |
@seladb |
@gyl30 I think it's possible to reproduce through a unit test. Probably you can consider providing a minimum reproducible test case. |
It is a common windows behaviour |
@hidd3ncod3s there is a link to a pcapng flie, but unfortunately it's broken 😕
@gyl30 maybe you can write such program, record the TCP traffic, and attach a pcap file to this issue? |
@seladb @hidd3ncod3s @tigercosmos |
Same problem, I should have caught it earlier |
@gyl30 how come the TCP flow doesn't start with SYN? 🤔 |
PcapPlusPlus works fine if you start from the SYN of the TCP stream, the problem I encountered in my client environment did not capture the SYN of the TCP stream for some unknown reason.Keep-Alive.zip was intentionally caused by me in order to reproduce the problem. I now know that this phenomenon is not a problem. This issue can be closed now. |
I recently discovered an interesting phenomenon in a customer environment where TCP Keep-Alive packets appear every second or so and carry a byte of data, these Keep-Alive packets carry data that is intermingled with the normal data and can be passed through TcpReassembly. do we have a way to deal with this situation at PcapPlusPlus? Do we have a way in PcapPlusPlus to handle this situation? I have a screenshot here of Keep-Alive and HTTP data together, causing an error in HTTP parsing.
The text was updated successfully, but these errors were encountered: