Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router.__call__ does not handle interrupted system calls in select #9

Open
Ronen2 opened this issue Oct 7, 2016 · 1 comment
Open

Comments

@Ronen2
Copy link

Ronen2 commented Oct 7, 2016

I'm integrating pyxs within a twisted base application.
I hit an issue where the select.select() call within Router.call was interrupted.
This call is within a try block without any except clause. It does not handle interrupted system calls within the select system call.
It seems that any error from select.select() would end up with a select.error exception which is not caught and the Router connection is terminated.
Is it right to catch such exception and re-issue the select.select() call?

@superbobry
Copy link
Collaborator

Is it right to catch such exception and re-issue the select.select() call?

Yes, that sounds right. I'd welcome a PR with the try-except and a test for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants