Skip to content

Commit

Permalink
[java] Removing exceptions from accepted W3C caps
Browse files Browse the repository at this point in the history
Given that we are not analysing the response payload anymore.
  • Loading branch information
diemol committed Jun 8, 2022
1 parent 9435a8a commit 247abe7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 15 deletions.
12 changes: 0 additions & 12 deletions java/src/org/openqa/selenium/AcceptedW3CCapabilityKeys.java
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,6 @@ public class AcceptedW3CCapabilityKeys implements Predicate<String> {
"^proxy$",
"^setWindowRect$",
"^strictFileInteractability$",
// TODO: Needs to be removed when ChromeDriver issue is resolved. Not a W3C capability
// https://bugs.chromium.org/p/chromedriver/issues/detail?id=4129
"^networkConnectionEnabled$",
// TODO: Needs to be removed when ChromeDriver issue is resolved. Not a W3C capability
// https://bugs.chromium.org/p/chromedriver/issues/detail?id=4129
"^chrome$",
// TODO: Needs to be removed when MSEdgeDriver issue is resolved. Not a W3C capability
// https://github.com/MicrosoftEdge/EdgeWebDriver/issues/23
"^msedge$",
// TODO: Needs to be removed when GeckoDriver issue is resolved. Not a W3C capability
// https://github.com/mozilla/geckodriver/issues/2023
"^platformVersion$",
"^timeouts$",
"^unhandledPromptBehavior$",
"^webSocketUrl$") // from webdriver-bidi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@
public class InternetExplorerDriverTest extends JUnit4TestBase {

@Test
public void builderGeneratesDefaultChromeOptions() {
public void builderGeneratesDefaultIEOptions() {
WebDriver driver = InternetExplorerDriver.builder().build();
driver.quit();
}

@Test
public void builderOverridesDefaultChromeOptions() {
public void builderOverridesDefaultIEOptions() {
InternetExplorerOptions options = new InternetExplorerOptions();
options.setImplicitWaitTimeout(Duration.ofMillis(1));
WebDriver driver = InternetExplorerDriver.builder().oneOf(options).build();
Expand All @@ -57,7 +57,7 @@ public void builderOverridesDefaultChromeOptions() {
}

@Test
public void builderWithClientConfigthrowsException() {
public void builderWithClientConfigThrowsException() {
ClientConfig clientConfig = ClientConfig.defaultConfig().readTimeout(Duration.ofMinutes(1));
RemoteWebDriverBuilder builder = InternetExplorerDriver.builder().config(clientConfig);

Expand Down

0 comments on commit 247abe7

Please sign in to comment.