Amend default node config to allow users to override event bus flags

SeleniumHQ · Oct 11, 2021 · cb873db · cb873db
1 parent 81612e8
commit cb873db
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/java/src/org/openqa/selenium/events/zeromq/ZeroMqEventBus.java b/java/src/org/openqa/selenium/events/zeromq/ZeroMqEventBus.java
@@ -63,7 +63,7 @@ public static EventBus create(Config config) {
         return mungeUri(uri, "tcp", 4442);
       });
 
-    String subscribe = config.get(EVENTS_SECTION, "publish")
+    String subscribe = config.get(EVENTS_SECTION, "subscribe")
       .orElseGet(() -> {
         URI uri = config.get("node", "hub-address")
           .map(Urls::from)

diff --git a/java/src/org/openqa/selenium/grid/node/httpd/DefaultNodeConfig.java b/java/src/org/openqa/selenium/grid/node/httpd/DefaultNodeConfig.java
@@ -25,9 +25,12 @@ class DefaultNodeConfig extends MapConfig {
 
   DefaultNodeConfig() {
     super(ImmutableMap.of(
-        "events", ImmutableMap.of(
-            "publish", "tcp://*:4442",
-            "subscribe", "tcp://*:4443"),
+      "node", ImmutableMap.of(
+        // We use this instead of setting the default ports for
+        // the publish and subscribe ports of the event bus so
+        // that people can use the `--hub` flag safely.
+        "hub-address", "http://0.0.0.0:4444"
+      ),
       "server", ImmutableMap.of(
         "port", 5555)));
   }