fix: use proper query for searching title

semantic-release · Feb 15, 2018 · edecf92 · edecf92
1 parent fbf1246
commit edecf92
Show file tree

Hide file tree

Showing 5 changed files with 52 additions and 52 deletions.
diff --git a/lib/find-sr-issues.js b/lib/find-sr-issues.js
@@ -2,7 +2,7 @@ const ISSUE_ID = require('./definitions/sr-issue-id');
 
 module.exports = async (github, title, owner, repo) => {
   const {data: {items: issues}} = await github.search.issues({
-    q: `title:${title}+repo:${owner}/${repo}+type:issue+state:open`,
+    q: `in:title+repo:${owner}/${repo}+type:issue+state:open+${title}`,
   });
 
   return issues.filter(issue => issue.body && issue.body.includes(ISSUE_ID));

diff --git a/test/fail.test.js b/test/fail.test.js
@@ -47,9 +47,9 @@ test.serial('Open a new issue with the list of errors', async t => {
   ];
   const github = authenticate()
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []})
     .post(`/repos/${owner}/${repo}/issues`, {
@@ -80,9 +80,9 @@ test.serial('Open a new issue with the list of errors and custom title and comme
   ];
   const github = authenticate()
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []})
     .post(`/repos/${owner}/${repo}/issues`, {
@@ -112,9 +112,9 @@ test.serial('Open a new issue with assignees and the list of errors', async t =>
   ];
   const github = authenticate()
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []})
     .post(`/repos/${owner}/${repo}/issues`, {
@@ -145,9 +145,9 @@ test.serial('Open a new issue without labels and the list of errors', async t =>
   ];
   const github = authenticate()
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []})
     .post(`/repos/${owner}/${repo}/issues`, {
@@ -182,9 +182,9 @@ test.serial('Update the first existing issue with the list of errors', async t =
   ];
   const github = authenticate()
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: issues})
     .post(`/repos/${owner}/${repo}/issues/2/comments`, {

diff --git a/test/find-sr-issue.test.js b/test/find-sr-issue.test.js
@@ -45,9 +45,9 @@ test.serial('Filter out issues without ID', async t => {
   ];
   const github = authenticate({githubToken})
     .get(
-      `/search/issues?q=${escape(`title:${title}`)}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
         'state:open'
-      )}`
+      )}+${escape(title)}`
     )
     .reply(200, {items: issues});
 
@@ -69,9 +69,9 @@ test.serial('Return empty array if not issues found', async t => {
   const issues = [];
   const github = authenticate({githubToken})
     .get(
-      `/search/issues?q=${escape(`title:${title}`)}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
         'state:open'
-      )}`
+      )}+${escape(title)}`
     )
     .reply(200, {items: issues});
 
@@ -90,9 +90,9 @@ test.serial('Return empty array if not issues has matching ID', async t => {
   const issues = [{number: 1, body: 'Issue 1 body', title}, {number: 2, body: 'Issue 2 body', title}];
   const github = authenticate({githubToken})
     .get(
-      `/search/issues?q=${escape(`title:${title}`)}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
         'state:open'
-      )}`
+      )}+${escape(title)}`
     )
     .reply(200, {items: issues});
 

diff --git a/test/integration.test.js b/test/integration.test.js
@@ -200,9 +200,9 @@ test.serial('Comment on PR included in the releases', async t => {
     .post(`/repos/${owner}/${repo}/issues/1/comments`, {body: /This PR is included/})
     .reply(200, {html_url: 'https://github.com/successcomment-1'})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []});
 
@@ -228,9 +228,9 @@ test.serial('Open a new issue with the list of errors', async t => {
     .get(`/repos/${owner}/${repo}`)
     .reply(200, {permissions: {push: true}})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []})
     .post(`/repos/${owner}/${repo}/issues`, {
@@ -289,9 +289,9 @@ test.serial('Verify, release and notify success', async t => {
     .post(`/repos/${owner}/${repo}/issues/1/comments`, {body: /This PR is included/})
     .reply(200, {html_url: 'https://github.com/successcomment-1'})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []});
   const githubUpload1 = upload({
@@ -338,9 +338,9 @@ test.serial('Verify and notify failure', async t => {
     .get(`/repos/${owner}/${repo}`)
     .reply(200, {permissions: {push: true}})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []})
     .post(`/repos/${owner}/${repo}/issues`, {

diff --git a/test/success.test.js b/test/success.test.js
@@ -64,9 +64,9 @@ test.serial('Add comment to PRs associated with release commits and issues close
     .post(`/repos/${owner}/${repo}/issues/4/comments`, {body: /This issue has been resolved/})
     .reply(200, {html_url: 'https://github.com/successcomment-4'})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []});
 
@@ -126,9 +126,9 @@ test.serial('Make multiple search queries if necessary', async t => {
     .post(`/repos/${owner}/${repo}/issues/6/comments`, {body: /This PR is included/})
     .reply(200, {html_url: 'https://github.com/successcomment-6'})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []});
 
@@ -161,9 +161,9 @@ test.serial('Do not add comment if no PR is associated with release commits', as
     )
     .reply(200, {items: []})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []});
 
@@ -199,9 +199,9 @@ test.serial('Add custom comment', async t => {
     })
     .reply(200, {html_url: 'https://github.com/successcomment-1'})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: []});
 
@@ -238,9 +238,9 @@ test.serial('Ignore errors when adding comments and closing issues', async t =>
     .post(`/repos/${owner}/${repo}/issues/2/comments`, {body: /This PR is included/})
     .reply(200, {html_url: 'https://github.com/successcomment-2'})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: issues})
     .patch(`/repos/${owner}/${repo}/issues/2`, {state: 'closed'})
@@ -284,9 +284,9 @@ test.serial('Close open issues when a release is successful', async t => {
     )
     .reply(200, {items: []})
     .get(
-      `/search/issues?q=${escape(`title:${failTitle}`)}+${escape(`repo:${owner}/${repo}`)}+${escape(
-        'type:issue'
-      )}+${escape('state:open')}`
+      `/search/issues?q=${escape('in:title')}+${escape(`repo:${owner}/${repo}`)}+${escape('type:issue')}+${escape(
+        'state:open'
+      )}+${escape(failTitle)}`
     )
     .reply(200, {items: issues})
     .patch(`/repos/${owner}/${repo}/issues/2`, {state: 'closed'})