fix: replace deprecated Tags API call #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces calls to the deprecated Tags API endpoints with equivalent calls to the Releases API.
nfriend
force-pushed
the
nfriend-migrate-from-deprecated-api-endpoints
branch
from
3292c20
to
4c716c2
Compare
nfriend
changed the title
no worries, we can change the commit message with the squash & merge feature |
gr2m
approved these changes
Dec 8, 2020
|
🎉 This PR is included in version 6.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
nfriend
changed the title
|
Awesome, thanks @gr2m! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #183 by updating all requests to:
to instead call:
The former is deprecated and will be removed in GitLab 14.0 (in May 2021); see https://gitlab.com/gitlab-org/gitlab/-/issues/290311.
This has the added benefit of simplifying the process of uploading assets. The Releases API allows a release to be created with assets in a single request, removing the need to create assets separately.
This change is backwards compatible (the Releases API has been available since GitLab 11.7 - when the releases feature itself was delivered) and shouldn't impact current users of this plugin.
Testing
I've tested this change in a test project on GitLab.com: