refactor(registry): extract a constant rather than repeating the url string

Author: travi

lib/definitions/constants.js

@@ -0,0 +1 @@
+export const OFFICIAL_REGISTRY = 'https://registry.npmjs.org/';

lib/get-registry.js

@@ -1,6 +1,7 @@
 import path from "path";
 import rc from "rc";
 import getRegistryUrl from "registry-auth-token/registry-url.js";
+import { OFFICIAL_REGISTRY } from "./definitions/constants.js";
 
 export default function ({ publishConfig: { registry } = {}, name }, { cwd, env }) {
   return (
@@ -10,7 +11,7 @@ export default function ({ publishConfig: { registry } = {}, name }, { cwd, env
       name.split("/")[0],
       rc(
         "npm",
-        { registry: "https://registry.npmjs.org/" },
+        { registry: OFFICIAL_REGISTRY },
         { config: env.NPM_CONFIG_USERCONFIG || path.resolve(cwd, ".npmrc") }
       )
     )

lib/get-release-info.js

@@ -1,8 +1,9 @@
 import normalizeUrl from "normalize-url";
+import { OFFICIAL_REGISTRY } from "./definitions/constants.js";
 
 export default function (
   { name },
-  { env: { DEFAULT_NPM_REGISTRY = "https://registry.npmjs.org/" }, nextRelease: { version } },
+  { env: { DEFAULT_NPM_REGISTRY = OFFICIAL_REGISTRY }, nextRelease: { version } },
   distTag,
   registry
 ) {

lib/set-npmrc-auth.js

@@ -5,12 +5,13 @@ import getAuthToken from "registry-auth-token";
 import nerfDart from "nerf-dart";
 import AggregateError from "aggregate-error";
 import getError from "./get-error.js";
+import { OFFICIAL_REGISTRY } from "./definitions/constants.js";
 
 export default async function (npmrc, registry, { cwd, env: { NPM_TOKEN, NPM_CONFIG_USERCONFIG }, logger }) {
   logger.log("Verify authentication for registry %s", registry);
   const { configs, ...rcConfig } = rc(
     "npm",
-    { registry: "https://registry.npmjs.org/" },
+    { registry: OFFICIAL_REGISTRY },
     { config: NPM_CONFIG_USERCONFIG || path.resolve(cwd, ".npmrc") }
   );
 

lib/verify-auth.js

@@ -4,6 +4,7 @@ import AggregateError from "aggregate-error";
 import getRegistry from "./get-registry.js";
 import setNpmrcAuth from "./set-npmrc-auth.js";
 import getError from "./get-error.js";
+import { OFFICIAL_REGISTRY } from "./definitions/constants.js";
 
 function registryIsDefault(registry, DEFAULT_NPM_REGISTRY) {
   return normalizeUrl(registry) === normalizeUrl(DEFAULT_NPM_REGISTRY);
@@ -16,7 +17,7 @@ function targetingDefaultRegistryButNoTokenProvided(registry, DEFAULT_NPM_REGIST
 export default async function (npmrc, pkg, context) {
   const {
     cwd,
-    env: { DEFAULT_NPM_REGISTRY = "https://registry.npmjs.org/", ...env },
+    env: { DEFAULT_NPM_REGISTRY = OFFICIAL_REGISTRY, ...env },
     stdout,
     stderr,
     logger,

test/get-registry.test.js

@@ -3,11 +3,12 @@ import test from "ava";
 import fs from "fs-extra";
 import { temporaryDirectory } from "tempy";
 import getRegistry from "../lib/get-registry.js";
+import { OFFICIAL_REGISTRY } from "../lib/definitions/constants.js";
 
 test("Get default registry", (t) => {
   const cwd = temporaryDirectory();
-  t.is(getRegistry({ name: "package-name" }, { cwd, env: {} }), "https://registry.npmjs.org/");
-  t.is(getRegistry({ name: "package-name", publishConfig: {} }, { cwd, env: {} }), "https://registry.npmjs.org/");
+  t.is(getRegistry({ name: "package-name" }, { cwd, env: {} }), OFFICIAL_REGISTRY);
+  t.is(getRegistry({ name: "package-name", publishConfig: {} }, { cwd, env: {} }), OFFICIAL_REGISTRY);
 });
 
 test('Get the registry configured in ".npmrc" and normalize trailing slash', async (t) => {

test/get-release-info.test.js

@@ -1,13 +1,14 @@
 import test from "ava";
 import getReleaseInfo from "../lib/get-release-info.js";
+import { OFFICIAL_REGISTRY } from "../lib/definitions/constants.js";
 
 test("Default registry and scoped module", async (t) => {
   t.deepEqual(
     await getReleaseInfo(
       { name: "@scope/module" },
       { env: {}, nextRelease: { version: "1.0.0" } },
       "latest",
-      "https://registry.npmjs.org/"
+      OFFICIAL_REGISTRY
     ),
     {
       name: "npm package (@latest dist-tag)",

test/verify-auth.test.js

@@ -1,8 +1,9 @@
 import test from "ava";
 import * as td from "testdouble";
+import {OFFICIAL_REGISTRY} from '../lib/definitions/constants.js';
 
 let execa, verifyAuth, getRegistry, setNpmrcAuth;
-const DEFAULT_NPM_REGISTRY = "https://registry.npmjs.org/";
+const DEFAULT_NPM_REGISTRY = OFFICIAL_REGISTRY;
 const npmrc = "npmrc contents";
 const pkg = {};
 const otherEnvVars = { foo: "bar" };