Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings of dependency npm #333

Open
KaiSchwarz-cnic opened this issue Jan 25, 2021 · 3 comments
Open

Warnings of dependency npm #333

KaiSchwarz-cnic opened this issue Jan 25, 2021 · 3 comments

Comments

@KaiSchwarz-cnic
Copy link

Probably you're aware of it, just wanted to bring it up.

npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated har-validator@5.1.5: this library is no longer supported
└─┬ semantic-release@17.3.7
  └─┬ @semantic-release/npm@7.0.10
    └─┬ npm@6.14.11
      ├─┬ node-gyp@5.1.0
      │ └── request@2.88.0  deduped
      └── request@2.88.0 


└─┬ semantic-release@17.3.7
  └─┬ @semantic-release/npm@7.0.10
    └─┬ npm@6.14.11
      └─┬ request@2.88.0
        └── har-validator@5.1.5 

No idea about the exact use of npm as dependency, I could imagine this to be a relict of the npm security issue that github bumped up quite a while ago. Maybe moving it into engines section in package.json does it already.

Just my 2 cents / HTH.

@gr2m
Copy link
Member

gr2m commented Jan 25, 2021

this will be resolved with the upgrade to npm v7, we have an open PR here: #304

I can't find the time to look into the failing CI. Maybe you can help out?

@KaiSchwarz-cnic
Copy link
Author

Hi @gr2m,

being busy applies to so much people - I am including myself in here too. Just check my commit stats. If I get a spot, I'll try to support you. But don't expect something in short.

I also want to forward my biggest thanks for the work on this module. semantic-release and related plugins are so great. We use it in all our public repositories, also for the non-nodejs related ones!

Best
Kai

@danez
Copy link
Contributor

danez commented Apr 9, 2021

This should now be solved with 7.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants