Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating from 7.0.9 to 7.1.0 breaks audit-ci #354

Open
daviddelusenet opened this issue Apr 7, 2021 · 4 comments
Open

Updating from 7.0.9 to 7.1.0 breaks audit-ci #354

daviddelusenet opened this issue Apr 7, 2021 · 4 comments

Comments

@daviddelusenet
Copy link

daviddelusenet commented Apr 7, 2021

I'm using the audit-ci package in my project. When I update my @semantic-release/npm dependency from version 7.0.9 to 7.1.0 audit-ci breaks working.

The error I'm getting is:

Cannot convert undefined or null to object
Exiting...

I've already opened an issue in audit-ci: IBM/audit-ci#176

Please let me know if you need any more information.

@gr2m
Copy link
Member

gr2m commented Apr 8, 2021

let's wait for them to ship npm7 support and see if the problem persists. Please keep us posted

@daviddelusenet
Copy link
Author

daviddelusenet commented Apr 9, 2021

Probably not. 😄

However, shouldn't have been the update from NPM 6 to 7 be a breaking change? Since it's actually breaking stuff..

@danez
Copy link
Contributor

danez commented Apr 9, 2021

npm should only be used internally here. I'm not really sure why audit-ci is using the version that semantic-release installs. To me this sounds like a problem in audit-ci as it is using the wrong npm version but does not specify any dependency on npm itself.

@amclin
Copy link

amclin commented Apr 9, 2021

#357 may be related

Seems mixing NPM 7 as a dependency into stacks that don't explicitly use NPM 7 is problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants