-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad IsDualSemigroupRep
implication
#885
Comments
Thanks for the report @fingolfin but I'm fairly sure we've fixed this already in: Despite the misleading name, Maybe I need to make a release to incorporate the change in the commit mentioned above, I can do that! |
Ah, sorry, the above was based on a CI run from a few weeks (?) ago, so perhaps there was already a newer release that contains the fix. Sorry for not checking more carefully! |
No problem, I'm not sure I've released a version with that change yet, but I can do it this week. |
There is no need to hurry. I plan to release GAP 4.12.1 this week, but I don't think there is a need to include this new release of semigroups; if it is "too late" it'll just be in 4.12.2 which I right now hope to release in mid-December |
Resolved in 5.1.0 |
This code is problematic:
InstallTrueMethod(IsDualSemigroupRep, IsSemigroup and IsDualSemigroupElementCollection);
A representation is type information / encodes the internal layout of an object; it is not a mathematical property and as such should not be implied in this way.
This is in a way a return of the problem from issue #556 and is the main blocker for the GAP PR gap-system/gap#3006
The text was updated successfully, but these errors were encountered: