Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object as a paramter to transfer() method #3

Open
dinc334 opened this issue Mar 21, 2019 · 1 comment
Open

Add object as a paramter to transfer() method #3

dinc334 opened this issue Mar 21, 2019 · 1 comment
Labels
wontfix This will not be worked on

Comments

@dinc334
Copy link
Contributor

dinc334 commented Mar 21, 2019

I am trying to create transaction with specific data.
Based on Semux docs .transfer() method has 3 required paramaters - from, to and value.
Working Code without data

try {
  var txHash = await sem.transfer( 
      from.address,'0x541365fe0818ea0d2d7ab7f7bc79f719f5f72227', amount);
} catch(e) {
console.log(e);
}

Bad code with wrapped object

try {
	var txHash = await sem.transfer({
		from: from.address, 
		to: '0x541365fe0818ea0d2d7ab7f7bc79f719f5f72227', 
		value: amount,
		data: '0x746970'
	});
} catch(e) {
     console.log(e);
}

Trace error:

{ Error: Required parameter to was null or undefined when calling transfer.
    at new RequiredError (./node_modules/semux-js/dist/semux.umd.js:9980:28)
    at Object.transfer (./node_modules/semux-js/dist/semux.umd.js:11197:23)
    at Object.transfer (./node_modules/semux-js/dist/semux.umd.js:12134:78)
    at SemuxApi.transfer (./node_modules/semux-js/dist/semux.umd.js:12605:47)
    at sendCoins (./index.js:75:26)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7) field: 'to' }

So, can we add object as a parameter in order to remove the need to specify optional parameters. Like this:

sem.transfer(from,to,value, null, null.null, null, '0x00');
@honeycrypto honeycrypto added the wontfix This will not be worked on label Jul 15, 2019
@honeycrypto
Copy link
Contributor

This API is auto generated by Swagger. I agree that interface is not ideal, but it will require quite some time to rewrite and maintain all these changes. Also, there is no sense to modify only transfer method as requested, most functions have many optional parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants