You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- The breaking change actually happened in [version 2.3.0](https://github.com/sendgrid/python-http-client/releases/tag/v2.3.0), which I mistakenly applied a minor version bump.
116
-
- This version replaces error handling via HTTPError from urllib in favor of custom error handling via the [HTTPError class](https://github.com/sendgrid/python-http-client/blob/master/python_http_client/exceptions.py).
116
+
- This version replaces error handling via HTTPError from urllib in favor of custom error handling via the [HTTPError class](python_http_client/exceptions.py).
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+5-5Lines changed: 5 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -78,7 +78,7 @@ cd python-http-client
78
78
79
79
##### Execute: #####
80
80
81
-
See the [examples folder](https://github.com/sendgrid/python-http-client/tree/master/examples) to get started quickly.
81
+
See the [examples folder](examples) to get started quickly.
82
82
83
83
<aname="understanding-the-codebase"></a>
84
84
## Understanding the Code Base
@@ -93,11 +93,11 @@ Unit and profiling tests.
93
93
94
94
**/python_http_client/client.py**
95
95
96
-
An HTTP client with a fluent interface using method chaining and reflection. By returning self on [__getattr__](https://github.com/sendgrid/python-http-client/blob/master/client.py#L74) and [_()](https://github.com/sendgrid/python-http-client/blob/master/client.py#L70), we can dynamically build the URL using method chaining and [__getattr__](https://github.com/sendgrid/python-http-client/blob/master/client.py#L74) allows us to dynamically receive the method calls to achieve reflection.
96
+
An HTTP client with a fluent interface using method chaining and reflection. By returning self on [__getattr__](python_http_client/client.py#L198), we can dynamically build the URL using method chaining and [__getattr__](python_http_client/client.py#L198) allows us to dynamically receive the method calls to achieve reflection.
97
97
98
98
This allows for the following mapping from a URL to a method chain:
99
99
100
-
`/api_client/{api_key_id}/version` maps to `client.api_client._(api_key_id).version.<method>()` where <method> is a [HTTP verb](https://github.com/sendgrid/python-http-client/blob/master/client.py#L24).
100
+
`/api_client/{api_key_id}/version` maps to `client.api_client._(api_key_id).version.<method>()` where <method> is a [HTTP verb](python_http_client/client.py#L69).
101
101
102
102
**/python_http_client/config.py**
103
103
@@ -108,9 +108,9 @@ Loads the environment variables, if applicable.
108
108
109
109
All PRs require passing tests before the PR will be reviewed.
110
110
111
-
All test files are in the [`tests`](https://github.com/sendgrid/python-http-client/tree/master/tests) directory.
111
+
All test files are in the [`tests`](tests) directory.
112
112
113
-
For the purposes of contributing to this repo, please update the [`test_unit.py`](https://github.com/sendgrid/python-http-client/blob/master/test/test_unit.py) file with unit tests as you modify the code.
113
+
For the purposes of contributing to this repo, please update the [`test_unit.py`](tests/test_unit.py) file with unit tests as you modify the code.
Copy file name to clipboardExpand all lines: first-timers.md
+2-2Lines changed: 2 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -33,15 +33,15 @@ To make a pull request, follow these steps:
33
33
feature to tidy up your commits before making them public. Probably you will also have to create tests (if needed) or create or update the example code that demonstrates the functionality of this change to the code.
34
34
6.__Locally merge (or rebase)__ the upstream development branch into your topic branch:
35
35
```
36
-
git pull [--rebase] upstream master
36
+
git pull [--rebase] upstream main
37
37
```
38
38
39
39
7.__Push__ your topic branch up to your fork:
40
40
```
41
41
git push origin <topic-branch-name>
42
42
```
43
43
8.__[Open a Pull Request](https://help.github.com/articles/creating-a-pull-request/#changing-the-branch-range-and-destination-repository/)__
44
-
with a clear title and description against the `master` branch. All tests must be passing before we will review the PR.
44
+
with a clear title and description against the `main` branch. All tests must be passing before we will review the PR.
45
45
### Important notice
46
46
Before creating a pull request, make sure that you respect the repository's constraints regarding contributions. You can find them in the [CONTRIBUTING.md](./CONTRIBUTING.md) file.
47
47
## Repositories with Open, Easy, Help Wanted, Issue Filters
0 commit comments