Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency to Go sendgrid/rest library #94

Closed
thinkingserious opened this issue Oct 11, 2016 · 9 comments
Closed

Remove dependency to Go sendgrid/rest library #94

thinkingserious opened this issue Oct 11, 2016 · 9 comments
Assignees
@suchitparikh
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 11, 2016 •
edited
Loading

Issue Summary

Remove the dependency to https://github.com/sendgrid/rest, bringing the http client functionality into the library.

Once this one is closed, I can merge this: sendgrid/rest#14
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community hacktoberfest labels Oct 11, 2016
@thinkingserious thinkingserious mentioned this issue Oct 11, 2016
Closed
@guiferpa
Copy link

🤕 Already closed ? hahahaha'

@thinkingserious
Copy link
Contributor Author

@gpaixao #93 is closed, this one is ready to go :)

@suchitparikh suchitparikh self-assigned this Oct 11, 2016
@suchitparikh
Copy link
Contributor

@thinkingserious - Got this one

This was referenced Oct 12, 2016
Closed
Closed
@thinkingserious thinkingserious mentioned this issue Oct 25, 2016
Closed
@thinkingserious
Copy link
Contributor Author

@suchitparikh are you still interested in closing this one out?

@thinkingserious thinkingserious added the difficulty: medium fix is medium in difficulty label Oct 1, 2017
@leandro-lugaresi
Copy link
Contributor

leandro-lugaresi commented Oct 1, 2017 •
edited
Loading

@thinkingserious Got this one! But I have a question. We will not break compatibility, right?

@thinkingserious
Copy link
Contributor Author

@leandro-lugaresi,

Please hold on this one. We have an incoming issue this week that will likely make this issue obsolete.

Thanks!

With Best Regards,

Elmer

@tariq1890 tariq1890 mentioned this issue Oct 4, 2017
Closed
@tariq1890
Copy link
Contributor

@thinkingserious When would this be closed?

@tariq1890 tariq1890 mentioned this issue Oct 12, 2017
Merged
@thinkingserious
Copy link
Contributor Author

Hi @tariq1890,

#152 will close this one. Thanks!

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap and removed status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Mar 6, 2018
@thinkingserious
Copy link
Contributor Author

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suchitparikh suchitparikh

Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thinkingserious @leandro-lugaresi @suchitparikh @tariq1890 @guiferpa