Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Exception Handling for the Mail Helper #754

Closed
thinkingserious opened this issue Oct 20, 2018 · 0 comments · Fixed by #762
Closed

Type Exception Handling for the Mail Helper #754

thinkingserious opened this issue Oct 20, 2018 · 0 comments · Fixed by #762
Labels
difficulty: hard fix is hard in difficulty type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

The appropriate types necessary for a successful mail/send API call is documented here. We want to throw a type exception when the wrong type is provided.

Acceptance Criteria

  • All parameters for the mail\send endpoint are type checked and if they fail the type check and exception is thrown with instructions on how to fix
@thinkingserious thinkingserious added difficulty: hard fix is hard in difficulty hacktoberfest status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap labels Oct 20, 2018
@misantron misantron mentioned this issue Oct 27, 2018
Merged
6 tasks
@childish-sambino childish-sambino removed help wanted status: help wanted requesting help from the community labels Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: hard fix is hard in difficulty type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enhanced type exception handling misantron/sendgrid-php
2 participants
@thinkingserious @childish-sambino