Skip to content

Fix "similar-code" issue in sendgrid/helpers/mail/personalization.py #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thinkingserious opened this issue Oct 30, 2017 · 2 comments
Closed

Fix "similar-code" issue in sendgrid/helpers/mail/personalization.py #501

thinkingserious opened this issue Oct 30, 2017 · 2 comments
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Similar blocks of code found in 3 locations. Consider refactoring.

https://codeclimate.com/github/sendgrid/sendgrid-python/sendgrid/helpers/mail/personalization.py#issue_59f639d0343eae000100009f
@defaults
Copy link

defaults commented Oct 30, 2017 •
edited
Loading

@thinkingserious hey can you please code review and merge #493. I have fixed codeclimate issues with personalization.py

This was referenced Oct 30, 2017
Closed
Closed
@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Feb 27, 2018
@thinkingserious
Copy link
Contributor Author

Since there has been no activity on this issue since March 1, 2020, we are closing this issue. Please feel free to reopen or create a new issue if you still require assistance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor personalization.py as in issue #501 defaults/sendgrid-python
2 participants
@thinkingserious @defaults