Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParentSpanId will not be set on subcalls #10

Open
me23 opened this issue Dec 5, 2018 · 0 comments
Open

ParentSpanId will not be set on subcalls #10

me23 opened this issue Dec 5, 2018 · 0 comments

Comments

@me23
Copy link

me23 commented Dec 5, 2018

Hi,

I thought i found a little bug here:

I have a Client which calls Service A. Service A will make a call to Service B.
If I look at the spans in Zipkin i have one span: Client -> Service A
and another span: Service A -> Service B.

I expected one span: Client -> Service A -> Service B.

I made a little repo to show what i mean here: https://github.com/me23/seneca-zipkin-parentid-test.

I make a fork from this repo and make a quick and dirty fix https://github.com/me23/seneca-zipkin-tracer But because I have no
experience with zipkin and writing seneca-plugins, i'm not sure if it works like expected.

May be you could look over it?!

Greetings
me23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant