improve test coverage

Author: senko

dante/asyncdante.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from typing import Iterable
+from typing import AsyncGenerator
 
 import aiosqlite
 from pydantic import BaseModel
@@ -94,5 +94,7 @@ async def clear(self):
         await conn.execute(f"DELETE FROM {self.name}")
         await self.db._maybe_commit()
 
-    def __aiter__(self) -> Iterable[dict | BaseModel]:
-        return iter(self.find_many())
+    async def __aiter__(self) -> AsyncGenerator[dict | BaseModel]:
+        results = await self.find_many()
+        for r in results:
+            yield r

tests/test_async.py

@@ -72,6 +72,20 @@ async def test_find_none(db):
     assert result is None
 
 
+@pytest.mark.asyncio
+async def test_iteration(db):
+    coll = await db["test"]
+
+    await coll.insert({"a": 1})
+
+    count = 0
+    async for data in coll:
+        count += 1
+        assert data["a"] == 1
+
+    assert count == 1
+
+
 @pytest.mark.asyncio
 async def test_update_one(db):
     coll = await db["test"]
@@ -92,6 +106,15 @@ async def test_update_many(db):
     assert result["b"] == 3
 
 
+@pytest.mark.asyncio
+async def test_update_without_filter_fails(db):
+    coll = await db["test"]
+
+    await coll.insert({"a": 1, "b": 2})
+    with pytest.raises(ValueError):
+        await coll.update_many({})
+
+
 @pytest.mark.asyncio
 async def test_delete_one(db):
     coll = await db["test"]
@@ -115,6 +138,17 @@ async def test_delete_many(db):
     assert result == []
 
 
+@pytest.mark.asyncio
+async def test_delete_without_filter_fails(db):
+    coll = await db["test"]
+
+    with pytest.raises(ValueError):
+        await coll.delete_one()
+
+    with pytest.raises(ValueError):
+        await coll.delete_many()
+
+
 @pytest.mark.asyncio
 async def test_clear(db):
     coll = await db["test"]

tests/test_models.py

@@ -1,3 +1,4 @@
+import pytest
 from pydantic import BaseModel
 
 from dante import Dante
@@ -59,3 +60,21 @@ def test_update_model():
 
     assert result.a == 1
     assert result.b == "bar"
+
+
+def test_update_without_filter_fails():
+    db = Dante()
+    coll = db[MyModel]
+
+    obj = MyModel(a=1)
+
+    with pytest.raises(ValueError):
+        coll.update_many(obj)
+
+
+def test_delete_without_filter_fails():
+    db = Dante()
+    coll = db[MyModel]
+
+    with pytest.raises(ValueError):
+        coll.delete_many()

tests/test_sync.py

@@ -1,6 +1,8 @@
 from datetime import datetime
 from time import time
 
+import pytest
+
 from dante.sync import Dante
 
 
@@ -9,6 +11,7 @@ def test_create_dante_on_disk(tmp_path):
     db = Dante(db_path)
     assert db is not None
     _ = db["test"]
+    db.close()
     assert db_path.exists()
 
 
@@ -46,6 +49,17 @@ def test_insert_find_many():
     assert len(result) == 2
 
 
+def test_iteration():
+    db = Dante()
+    coll = db["test"]
+
+    coll.insert({"a": 1, "b": 2, "c": 3})
+
+    result = [d for d in coll]
+    assert len(result) == 1
+    assert result[0]["a"] == 1
+
+
 def test_insert_datetime():
     db = Dante()
     coll = db["test"]
@@ -84,6 +98,13 @@ def test_update_many():
     assert result["b"] == 3
 
 
+def test_update_without_filter_fails():
+    db = Dante()
+    coll = db["test"]
+    with pytest.raises(ValueError):
+        coll.update_many({})
+
+
 def test_delete_one():
     db = Dante()
     coll = db["test"]
@@ -105,6 +126,15 @@ def test_delete_many():
     assert result == []
 
 
+def test_delete_without_filter_fails():
+    db = Dante()
+    coll = db["test"]
+    with pytest.raises(ValueError):
+        coll.delete_many()
+    with pytest.raises(ValueError):
+        coll.delete_one()
+
+
 def test_clear():
     db = Dante()
     coll = db["test"]