Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow, sanitize and upload SVGs #8

Open
jamesdphillips opened this issue Feb 2, 2022 · 0 comments
Open

Allow, sanitize and upload SVGs #8

jamesdphillips opened this issue Feb 2, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jamesdphillips
Copy link
Contributor

jamesdphillips commented Feb 2, 2022 •
edited
Loading

SVGs are obviously quite handy due to their scalability and flexibility and as such it would be quite nice to have support for them as both the logo of an integration and within READMEs. The downside is that they're susceptible XSS and other unwanted behaviour and as such we'll want to sanitize them before we serve them.

  • DOMPurify is a great tool in the Javascript space but might not be feasible for this project
  • microcosm-cc/bluemonday seems like the most popular tool in the Go world, but it doesn't seem to support SVGs. The library does seem extensible enough where I think we could add support though.
@jamesdphillips jamesdphillips added the enhancement New feature or request label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamesdphillips