Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check config standalone boolean #34

Closed
foomatty opened this issue Mar 7, 2013 · 4 comments
Closed

check config standalone boolean #34

foomatty opened this issue Mar 7, 2013 · 4 comments

Comments

@foomatty
Copy link

foomatty commented Mar 7, 2013

Although it's defined as a boolean

f.puts JSON.pretty_generate(conf) seems to write it out as a string.

@jlambert121
Copy link
Contributor

I tried forcing a json to write a boolean many ways without success. There was some discussion tonight in #sensu about having sensu honor booleans as strings though. That might be the easiest fix for this.

@foomatty
Copy link
Author

foomatty commented Mar 8, 2013

I guess can just use templates in the meantime.

@phobos182
Copy link

I have a PR open to fix this. #43

The fix is to have undef by default. Then supplying true to the aggregate / standalone argument with the fix will apply this correctly to the resulting JSON file. No quotes, no strings.

@jamtur01
Copy link
Contributor

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants