Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis builds failing even on no code change #511

Closed
dalesit opened this issue Jun 17, 2016 · 2 comments
Closed

Travis builds failing even on no code change #511

dalesit opened this issue Jun 17, 2016 · 2 comments

Comments

@dalesit
Copy link

dalesit commented Jun 17, 2016

The Travis builds with Ruby 2.1.6 are all failing, regardless of code change (eg #510 which is not changing any code at all). It appears that all builds for Ruby 2.1.6 have failed since Travis build #922. I'm not sure what changed at that point.

@jaxxstorm
Copy link
Contributor

The problem is related to the apt module and a versioncmp function call:

Puppet::PreformattedError:
       Evaluation Error: Error while evaluating a Function Call, 'versioncmp' parameter 'a' expects a String value, got Undef at /home/travis/build/sensu/sensu-puppet/spec/fixtures/modules/apt/manifests/params.pp:125:15 on node testing-worker-linux-docker-e3eb7565-3390-linux-2.prod.travis-ci.org

Basically the lsbdistrelease fact isn't set in the spec tests, so it's doing a versioncmp against an undef value, which seems to no longer be valid.

I have a fix on the way

@dalesit
Copy link
Author

dalesit commented Jul 21, 2016

Excellent! That seems to have done the trick. Many thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants