Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository URLs and release new module version #606

Closed
GhostLyrics opened this issue Feb 6, 2017 · 18 comments
Closed

Update repository URLs and release new module version #606

GhostLyrics opened this issue Feb 6, 2017 · 18 comments

Comments

@GhostLyrics
Copy link

Please update the repository URLs according to the changes to packaging introduced with sensu 0.27.
Currently they still run with e.g. sensu/main instead of trusty for Ubuntu.

https://sensuapp.org/blog/2017/01/31/sensu-core-v0-27-0.html

@GhostLyrics
Copy link
Author

Is there any update on this?

@jaxxstorm
Copy link
Contributor

@GhostLyrics please send a pull request

@goodwolf
Copy link
Contributor

See my PR for yum. I will submit another for deb repos

@law
Copy link

law commented Mar 11, 2017

Any word on this for Ubuntu/debian systems?

@jaxxstorm
Copy link
Contributor

@law a PR would be appreciated

@goodwolf
Copy link
Contributor

Sorry humans, I was distracted by a field mouse. I will get on this.

@dzeleski
Copy link
Contributor

dzeleski commented Mar 13, 2017

I assume we will need to do the same for windows?

Repo path now includes a 2012r2 folder: https://sensu.global.ssl.fastly.net/msi/2012r2/

https://github.com/sensu/sensu-puppet/blob/master/manifests/package.pp#L55

Edit: I should have mentioned that I can create a PR for this if it has not been tackled by anyone else

@dzeleski
Copy link
Contributor

@jaxxstorm added some code in my fork to support windows repos:
https://github.com/dzeleski/sensu-puppet/blob/master/manifests/package.pp#L53-L75

This uses the kernel version so we dont need to rely on stdlib methods, but would require an update to the case if a new kernel was released. Default is set to 2012r2. Any issues with this method of setting the repo?

@dzeleski
Copy link
Contributor

@goodwolf The repo adds correctly for yum but the filename is incorrect so it cannot install properly. The version now includes .el(5-7). I had to append that to the sensu pkg_version var for redhat as seen here:

'RedHat': {
      $pkg_title = 'sensu'
      $pkg_name = 'sensu'
      $pkg_version = "${sensu::version}.el${::operatingsystemmajrelease}"
      $pkg_source = undef

      if $sensu::manage_repo {
        class { '::sensu::repo::yum': }
      }

      $pkg_require = undef
    }

https://github.com/dzeleski/sensu-puppet/blob/test_win_log_rotate/manifests/package.pp#L34

@jothoma1
Copy link

Any news on this ? it didnt install the latest version of sensu for me

@jothoma1
Copy link

Someone has an idea ? do i have to use @dzeleski fork ?
Thanks in advance

@dzeleski
Copy link
Contributor

@jothoma1 all of my PRs were merged for this. They are using redirects in the repo itself to support the naming change on windows. For RHEL I use specific the version I want installed:

0.27.0-1.el%{operatingsystemmajrelease}

I cant comment on debian as I dont use it at work.

@jothoma1
Copy link

@dzeleski thanks for your response. Sorry for the questions... I'm using it in Puppet with :

class { 'sensu':
rabbitmq_host => 'xxx',
rabbitmq_vhost => 'xxx',
rabbitmq_password => 'xx',
rabbitmq_port => '5671',
rabbitmq_ssl => true,
rabbitmq_reconnect_on_error => true,
use_embedded_ruby => true,
version => latest,
redact => [ 'password', 'pass', 'api_key', 'secret' ],
}

With version => latest, the repository (for CentOS) is not the good one and my sensu clients don't install latest updates. They are blocked on 0.26.5.

So if i understand, i have to specify the version ?
Can you give me an example ? for centos & windows ?

Thanks a lot

@dzeleski
Copy link
Contributor

dzeleski commented May 31, 2017

@jothoma1 for windows just use the version:
hiera: version: '0.27.1-7'
puppet: version => '0.27.1-7',

for cent/rhel use version plus the OS major version:
hiera: version: '0.27.1-7.el%{operatingsystemmajrelease}'
puppet: version => "0.27.1-7.el${facts['operatingsystemmajrelease']}",

@cwjohnston
Copy link
Contributor

I'm going to close this issue as I believe we've implemented the changes required to address these concerns. Version 2.4.0 of this module is now available on the forge.

@GhostLyrics
Copy link
Author

Just in case someone is not aware of this: unfortunately (for me) the newer version bringing the necessary changes to apt URLs also requires Puppet 4 which makes it impossible to use for me, for the time being.

@mvasilenko
Copy link

mvasilenko commented Dec 17, 2017

@GhostLyrics i've hit the same issue, puppet 3 only, how can i install sensu version >0.26.5 on Debian/Ubuntu?

@GhostLyrics
Copy link
Author

You either

  • do it manually
  • try to overwrite a lot of parameters of this module
  • or upgrade to Puppet 4.

I'm in the process of upgrading to Puppet 4 since I've put that off for too long anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants