Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client key/values? #80

Closed
blysik opened this issue May 23, 2013 · 5 comments · Fixed by #90
Closed

client key/values? #80

blysik opened this issue May 23, 2013 · 5 comments · Fixed by #90

Comments

@blysik
Copy link

blysik commented May 23, 2013

I can't tell from the docs, but can I define arbitrary key/values at a client level with this module?

@jamtur01
Copy link
Contributor

jamtur01 commented Jun 2, 2013

Not yet. We're working on how best to handle this.

@jlambert121
Copy link
Contributor

This is available as of #85.

@blysik
Copy link
Author

blysik commented Jun 7, 2013

Can you explain how #85 works? That lets me set key/value for a check, but I was under the impression that I have to set key/value on a client, to customize the keepalive handler. Hopefully I'm just misunderstanding how it works.

@blysik
Copy link
Author

blysik commented Jun 7, 2013

Yes, looking a little deeper, #85 lets us set custom key/value on a check, but to manage keepalive handlers, we need the ability to do custom key/value on a client.

@jlambert121
Copy link
Contributor

Sorry - you are correct. My brain saw check. This does not currently exist for clients. I can come back to it one of these days and add it for the client or feel free to submit a PR - it will likely be very close to #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants