Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post process forwarder: commit-batch-size=1 #138

Closed
joscha-alisch opened this issue Aug 4, 2020 · 2 comments · Fixed by #140
Closed

Post process forwarder: commit-batch-size=1 #138

joscha-alisch opened this issue Aug 4, 2020 · 2 comments · Fixed by #140

Comments

@joscha-alisch
Copy link
Contributor

Hi there :)

is there specific reason why commit batch size is set to 1 in the post-process-forward deployment? I've seen the app be able to process a much higher volume of post processing when I remove this option.

In case this can be removed, I am happy to provide a PR, either removing it altogether or at least making it configurable :)

@Mokto
Copy link
Contributor

Mokto commented Aug 4, 2020

The idea was to follow the official docker solution -> https://github.com/getsentry/onpremise/blob/master/docker-compose.yml#L172

But you can make it configurable if you want ;)

@joscha-alisch
Copy link
Contributor Author

Ah cool, it even says that this should be adapted according to needs in the comment. I'll get that PR ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants