feat: reintroduce "Extend Redis functionality" #1492

nadecancode · 2024-09-29T07:18:12Z

This PR reintroduces #914 with conflicts resolved.

Core Diff:

Addressed Extend Redis functionality #914 (comment) with a workaround that declares an additional environment variable that references the externalRedis secret then use https://kubernetes.io/docs/tasks/inject-data-application/define-interdependent-environment-variables/ to plug Redis URL in. The dependency resolution is handled by Kubernetes so it is secure.
Rename the password reference in values.yml for Redis subchart to redis.auth.password etc., this is because subchart relies on that path to create authentication so setting redis.password only will only break the integrated Redis connection (because Redis subchart will believe there is no password defined).
Remove the need to specify brokerUrl secrets, it'll compute based on the existing secrets specified in the values
Fixed misc issues that were failing the E2E

- Adds support to set REDIS_PASSWORD as a kubernetes secret. - Adds support to set externalredis.db too choose the db number - Adds support to use externalredis.ssl for secure ssl - Adds support to set externalredis.brokerUrl, this overrides the BROKER_URL environment variable that is used to set the broker with a secret.

nadecancode · 2024-09-29T08:07:48Z

@Mokto Please let me know if there is anything else I need to update. Thanks!

Update: Seems like the linting pipeline is failing because of Error: INSTALLATION FAILED: client rate limiter Wait returned an error: rate: Wait(n=1) would exceed context deadline. I am not exactly sure what is happening but does it have to do with how low the timeout threshold is in the ct install step?

patsevanton · 2024-09-29T14:07:38Z

I see in log

 Warning  Failed     13m (x12 over 16m)  kubelet            Error: secret "sentry-1qicb2mrxr-sentry-redis" not found

Error from server (BadRequest): container "sentry-web" in pod "sentry-1qicb2mrxr-web-67f575b88b-rflwm" is waiting to start: CreateContainerConfigError

…cret are empty

…cret are empty (another location)

nadecancode · 2024-09-29T17:48:22Z

I see in log

 Warning  Failed     13m (x12 over 16m)  kubelet            Error: secret "sentry-1qicb2mrxr-sentry-redis" not found

Error from server (BadRequest): container "sentry-web" in pod "sentry-1qicb2mrxr-web-67f575b88b-rflwm" is waiting to start: CreateContainerConfigError

Thanks for the response! I have fixed that problem but now I'm seeing

 Error: INSTALLATION FAILED: failed post-install: 1 error occurred:
	* job sentry-3v92k07w6y-snuba-migrate failed: DeadlineExceeded

in the pipeline now

…ubchart credential and referenced credential in Sentry deployments

nadecancode · 2024-09-30T00:42:33Z

Not really sure what is going on with these failed E2E tests.. I tried doing a dry-run between a passing build and my local one:

2c2
< LAST DEPLOYED: Sun Sep 29 17:36:24 2024
---
> LAST DEPLOYED: Sun Sep 29 17:28:45 2024
3439a3440
>   usePassword: false
4653c4654
<   key: "ZDY4OERieERJZHc5SzNkcnExMVc5Z0Q0TUJsZUNnMUFacUhTY2NPd0lxVGdvR2ticHE="
---
>   key: "V1hiZkREZ0lhMTBiSEFlazJZME00U3ZaQUVsMm14VEV3YW5vZWVBWm80MVB5SFZ5ZUg="
4683c4684
<         checksum/config.yaml: 5435d92f59d6600de5cc3737ac9fb9259ec4ed27eb59e108a3dc94928a4da9d3
---
>         checksum/config.yaml: af670a2d7768ac839632f2d6f8cc31bcb2dbc25564d07ccf07eca59cecf6de81
4784c4785
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
4881c4882
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
4978c4979
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5074c5075
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5170c5171
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5266c5267
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5363c5364
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5460c5461
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5557c5558
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5654c5655
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5750c5751
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5847c5848
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
5945c5946
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
6039c6040
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
6136c6137
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
6233c6234
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
6326c6327
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
6366,6367d6366
<         - name: REDIS_PORT
<           value:  "6379"
6410c6409
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
6450,6451d6448
<         - name: REDIS_PORT
<           value:  "6379"
6494c6491
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
6534,6535d6530
<         - name: REDIS_PORT
<           value:  "6379"
6578c6573
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
6618,6619d6612
<         - name: REDIS_PORT
<           value:  "6379"
6662c6655
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
6702,6703d6694
<         - name: REDIS_PORT
<           value:  "6379"
6746c6737
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
6786,6787d6776
<         - name: REDIS_PORT
<           value:  "6379"
6830c6819
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
6870,6871d6858
<         - name: REDIS_PORT
<           value:  "6379"
6914c6901
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
6958,6959d6944
<         - name: REDIS_PORT
<           value:  "6379"
7002c6987
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
7042,7043d7026
<         - name: REDIS_PORT
<           value:  "6379"
7086c7069
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
7113,7114d7095
<         - name: REDIS_PORT
<           value:  "6379"
7157c7138
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
7197,7198d7177
<         - name: REDIS_PORT
<           value:  "6379"
7241c7220
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
7281,7282d7259
<         - name: REDIS_PORT
<           value:  "6379"
7325c7302
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
7364,7365d7340
<         - name: REDIS_PORT
<           value:  "6379"
7408c7383
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
7448,7449d7422
<         - name: REDIS_PORT
<           value:  "6379"
7492c7465
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
7531,7532d7503
<         - name: REDIS_PORT
<           value:  "6379"
7575c7546
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
7615,7616d7585
<         - name: REDIS_PORT
<           value:  "6379"
8356c8325
<         checksum/configmap.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/configmap.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
8428c8397
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
8452,8453d8420
<         - name: REDIS_PORT
<           value:  "6379"
8496c8463
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
8515,8516d8481
<         - name: REDIS_PORT
<           value:  "6379"
8556c8521
<         checksum/configmap.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/configmap.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
8849c8814
<   kraft-cluster-id: "V2hnSGVsUThtdFZvVlF4RXJ4ODFYVQ=="
---
>   kraft-cluster-id: "ZmtmMWUxa1Q1RmljbUszR3dhemxicw=="
8865,8867c8830,8832
<   tls.crt: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURpRENDQW5DZ0F3SUJBZ0lSQUxjcTZzeVpEekp1dmRLWnFOdTJhZjR3RFFZSktvWklodmNOQVFFTEJRQXcKRXpFUk1BOEdBMVVFQXhNSWJtZHBibmd0WTJFd0hoY05NalF3T1RNd01EQXpOakkyV2hjTk1qVXdPVE13TURBegpOakkyV2pBWE1SVXdFd1lEVlFRREV3eHpaVzUwY25rdGJtZHBibmd3Z2dFaU1BMEdDU3FHU0liM0RRRUJBUVVBCkE0SUJEd0F3Z2dFS0FvSUJBUURZN2h3R3BWZHpJNXloS2JVQ0VQQXcwc1dKTmhpMXpQVUhPYkdNeVJOdU5BRWQKS2lXMG9UMWRFRlZtN3FDSXhrZm92VFN1bWp2Rm1aejhEVnN4RXh1SFRRTUJZbmdWaEMvMU5qd2FGZlV4Z3BEeQpHclMrR2tmcTFyVThOaE1qME9FZzdkY0NaMnE4THRHUkRwQmpWa1EyOXduUTRpR1c3Y09VdlZpNFc0ZTFkQWpOCnJCRXNscVZsWnlGaDQ1aUlJTG83eVlnNlF1MkVDN0hGOHZ4UGlmcjJVTGVxQVdsdFg3aDBSRWlFRDFHYVN3QmIKaGpQd09uRFZmakxxZ1E0dFRqTjRqbFpYditzeVdYYlN2VCs0MUxEOWI5UmR4d2VGQXBFbHBWUUpVT3dsa3VESwpWRjNuaTZmMlJCTlVqNkZiQnY3ekp1NE9yb0hEVGE2Qm9XRm9qcmkvQWdNQkFBR2pnZEl3Z2M4d0RnWURWUjBQCkFRSC9CQVFEQWdXZ01CMEdBMVVkSlFRV01CUUdDQ3NHQVFVRkJ3TUJCZ2dyQmdFRkJRY0RBakFNQmdOVkhSTUIKQWY4RUFqQUFNQjhHQTFVZEl3UVlNQmFBRkd6U2NXbXowUHF4VjFZUGZzZkdRandkN2tiQk1HOEdBMVVkRVFSbwpNR2FDREhObGJuUnllUzF1WjJsdWVJSVVjMlZ1ZEhKNUxXNW5hVzU0TG1SbFptRjFiSFNDR0hObGJuUnllUzF1CloybHVlQzVrWldaaGRXeDBMbk4yWTRJbWMyVnVkSEo1TFc1bmFXNTRMbVJsWm1GMWJIUXVjM1pqTG1Oc2RYTjAKWlhJdWJHOWpZV3d3RFFZSktvWklodmNOQVFFTEJRQURnZ0VCQURMaklwQnBxaUNpZmxaM1FxVy9ZTXVGdE03KwpReFVERE1GYTlHRnNtN2l2Z2c3eWQ3V2ZVWFRNNnV1cTAvQVQ1Uzh3Y0VqMi9LQ2FjNFlyWTY3S2F0YmxUZ2Y4ClVmOC9pdkJhcVZkN3prd1lqQjVSTW9Tbm5iTWtzcnU2UnRpNmNXRmxBLy9jR1dXakw1cmJ4c2VlcEY5WmZIK3AKVzVsa2NNUkxpSGxXMUNzVG5HVjRIekkzeGVKSmhHenRDTkMvU3ppQloydlFZa2NrY1UwQWpySU43alFkUU44VAp2Rm1mSVpobXFwdURlVzhsa1ZUMmI1UlVQaDVyK0k3U1BlaDhzbnlqaFEzSHNUOFRzcVA0aTFpWFJUblpWK0djCkVXMUtPNW9wU1dEdmFxK3lqQ2pNeUIwL3JxeVBYODlrTFFsczFxWDYrQllnemNvWmlnK0NaME9RRFc0PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
<   tls.key: LS0tLS1CRUdJTiBSU0EgUFJJVkFURSBLRVktLS0tLQpNSUlFcGdJQkFBS0NBUUVBMk80Y0JxVlhjeU9jb1NtMUFoRHdNTkxGaVRZWXRjejFCem14ak1rVGJqUUJIU29sCnRLRTlYUkJWWnU2Z2lNWkg2TDAwcnBvN3habWMvQTFiTVJNYmgwMERBV0o0RllRdjlUWThHaFgxTVlLUThocTAKdmhwSDZ0YTFQRFlUSTlEaElPM1hBbWRxdkM3UmtRNlFZMVpFTnZjSjBPSWhsdTNEbEwxWXVGdUh0WFFJemF3UgpMSmFsWldjaFllT1lpQ0M2TzhtSU9rTHRoQXV4eGZMOFQ0bjY5bEMzcWdGcGJWKzRkRVJJaEE5Um1rc0FXNFl6CjhEcHcxWDR5Nm9FT0xVNHplSTVXVjcvck1sbDIwcjAvdU5Tdy9XL1VYY2NIaFFLUkphVlVDVkRzSlpMZ3lsUmQKNTR1bjlrUVRWSStoV3diKzh5YnVEcTZCdzAydWdhRmhhSTY0dndJREFRQUJBb0lCQVFDWWRybVIzakZaUmlVMgpqQ2FnM2lEQ1g5RGYvL3BjQkVJT292anIxd0xtQ0h6ajc1UnlvSVNOWFFaNUFxd25sUnhETW4vTlc2ODQwUjhwCmM0V3ROeDI0K1dKc1hiWENnWlpuUklmM1dZbHNFN1VsdzZsV2x3Z0d3SUsrWDg4UjlDUFdUZk00eUZDWEZGek0KRTYxZGMrc2Jxb0xtb1pnMENNWFdTMElJeUtQWDNmdHlZY2M4NzZENy9RbGl0Ny9xdjVQZVZudHFwUnpjNGFwLwpyTlh3MFZ2bVBGNlhubi9PNktzOHhpajViRVJrdFFIaTRNN1VsL08vS0JzcWQyQkJKTFp2OUorMUhFaTJhRE1TClNuT0syT0tWcFd4WjZkdHNvZUZLaHB4YnFqTXFiR3hZRUxvUFM5Zk5YR2JhamZuZU8vOGtrNHV1N2xPNG15TTMKS2tCQ1VwT2hBb0dCQU9uODViVmwwSG83Zi9RYW1uc0tHWFdYbmlQU3RuZG8wSDZ0ajJWSytoSWxyVHF0VlZGcQp2Q3JOMm1UbkQzT3JVWEtpbjFFY3pFZmVTRWRPTERoUG5aQndXdndTMUQzdWdoMFd3Qmd2bWgydE14NmZibFZTCm5IcWR6b21NN2JtSEUwWXZibGI4Z3Y2bWFobmk0c2E4VG9OdlZvdXRuSzVaTjltL3NLeHJ2d054QW9HQkFPMVcKYVhwVnlLZEZ4Unhad2xibGcwUU5lTnB3KzZOQXQwc0g4UVhJTnAvSzdlR0hUUlhvUEloQnFLVG9Da24ySmRSbApnS2Fyekd0UitKbE5JK0lwb0lWN21RdmlBSWxSall1VENwUGJXV1FzbzV1aGd0MzliN1dGamlmMk44d2xTTG9lCjg5Mkl4QjJyZlBVQ1ZmYy9UMUNXcFUzUmErU0hBbFJnREJ4Qk5RY3ZBb0dCQU1qdUtQd0t3R29XcWh3ZXRFV3cKT0lpb2VGNWUxZDNZbmlJS1BMZEpHVkY0RlRmc0hQWGJhRmFCaTJkV25BaENONkR2VVV4QUpKUWFwNHJEOEdreQp4U1dCdGovOGsxSFRmTndwNnk5WndVaDJzUTA4NzJ4SmtxSWczWGwxRWJkZDdRazZOZEJ3NnJSdWgzSlBTVnBMCjNrZ3oxZWdBWUNtLzU1d1BabEhKL0sraEFvR0JBSm9aV1RNTkw5TXNBZWQrZ0NoYnJQY3FxQ1ZzNW5ZQk53R0kKam4zcW1VejNQYTBKWkl1czFtRENBUFhSazV5aUxiM1NpYzJ1RG5SQUxPR2NySWZUNzEyNytvczBtcFNPVnhFZwp6K1ZncnBIVVNnWnF2OFhUSUEwRVFtREFCVXFQaXNFT0I5ajNUQjdYa2JLamFaMjNoWkFWd0E3ZXd1Y0dvZ1NXCnVFWkFNR1lSQW9HQkFNTkIyTlRSRmhIaHZsR3FOcmZvdW5CbGFpZjRDQy8xVzdtOU1NTDQzZW50YURiVEM5em8KdDkrVGY1RjNuTmx3VUgzY1U3TVBBTHdSbWszV1pLNk1jZGEvdEk5eFJFekhtWVBsZUp1OGVGZk5PaFBjTWhzYQpNcDRNNzNURFl2UFB1SjRocTIydUlGU0ZjdDEveEpxeWFFY0txUDIrY0ZnSis2RVNvWUw4dnZkUgotLS0tLUVORCBSU0EgUFJJVkFURSBLRVktLS0tLQo=
<   ca.crt: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURFakNDQWZxZ0F3SUJBZ0lSQVBvZ0JwelJUL1JHQjJXNkFmZDdvM1l3RFFZSktvWklodmNOQVFFTEJRQXcKRXpFUk1BOEdBMVVFQXhNSWJtZHBibmd0WTJFd0hoY05NalF3T1RNd01EQXpOakkxV2hjTk1qVXdPVE13TURBegpOakkxV2pBVE1SRXdEd1lEVlFRREV3aHVaMmx1ZUMxallUQ0NBU0l3RFFZSktvWklodmNOQVFFQkJRQURnZ0VQCkFEQ0NBUW9DZ2dFQkFMT2gyUGFnVlRpQUVwLzl1eGpqOE1ZVDdoS3FTcXVNNExveVV3QnI5SXpzcExhNVp6dnAKNWNGbUFxOWp6UUNGOCtuWDY1ZnRhWTVGYmV5TlAxWFJSbTUzWFQrOFZ0OTEwZjUwZkNkVnhXN0FKbVBQZXJ6bApUMGVWVCtMMEYxWFVGa05EMkFwQUZHZ1kwRXcrOVAzaTFXM2hjbEw5VUhXWjZxYWVhRXFHRW1iVXRFYWJteW05CjNtQy9kWVZiNG5UcU9GZ1dIakVNdW5tQlpXa1RYVXN6aGFpd2tHNUFFbUduVUpkUjRQOE1BUnBBc09kRDUyTnMKODg4RFNwdDA2WDZ2SWZLcUhVMlk5M0lmSjdoV3hQWE5CMVlMc3NDeEUrVWZwdEszOHFNMHVzQllqQTNOSDNLdgpiQU9uZmhKN1JURk90czVMOVdrdnAvQ0x4cGNTeVZGRFhJY0NBd0VBQWFOaE1GOHdEZ1lEVlIwUEFRSC9CQVFECkFnS2tNQjBHQTFVZEpRUVdNQlFHQ0NzR0FRVUZCd01CQmdnckJnRUZCUWNEQWpBUEJnTlZIUk1CQWY4RUJUQUQKQVFIL01CMEdBMVVkRGdRV0JCUnMwbkZwczlENnNWZFdEMzdIeGtJOEhlNUd3VEFOQmdrcWhraUc5dzBCQVFzRgpBQU9DQVFFQVBOeDZvSWVGbzQ3V2wvQ1M2K1pwZEZtYmpiYUpZSTdCS24zQnZQOWdYMTgzMHpyY1hpTzBIS1o0CjFPcWhsWFF1cHdObVpWMExIYnJwRXdhL1pKcmFjQWJzM1lBeE5QR2pCb25XQVIxcDlUaHZQemlld0YybWtEbE8KNS9XbHlyRFVBeXZaanFjTG41ZHdGOVB2TkxTVlhlV1JHYzdlY1lSdnA1TTBrdVdwRXA2UGdtUnppRDRDT3R0SApYYmZiL2dEYzZrSHozOUVOQmFiRGhTZ21CbzVOSkxpbStLTjlMTFVUTFFLa1FTUUJ2MUtKak0xVEZ0TStzaFIyClU1d0pmYmVqWE5RWGEwcFA0cE1FRll2bkdLWGlhVDlzYitWbWNlVDlETlVvWExWUjcrSnNmTlkzU0tObDBDbFoKSUh4Z01KODQxNjlkdzhweDVmVjRHOFg3UlJ1ZWJRPT0KLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo=
---
>   tls.crt: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURoekNDQW0rZ0F3SUJBZ0lRWk9CbVoxUCt2cUU1ZkY2bGI4MHJ3ekFOQmdrcWhraUc5dzBCQVFzRkFEQVQKTVJFd0R3WURWUVFERXdodVoybHVlQzFqWVRBZUZ3MHlOREE1TXpBd01ESTRORFphRncweU5UQTVNekF3TURJNApORFphTUJjeEZUQVRCZ05WQkFNVERITmxiblJ5ZVMxdVoybHVlRENDQVNJd0RRWUpLb1pJaHZjTkFRRUJCUUFECmdnRVBBRENDQVFvQ2dnRUJBUGY3OXhZNERxT2toNkRLOWcrTlZHZEpHMmcwUXR3dUJtbkN0bmpJWkFwMERZdzQKQVgxbTJBelVBL3JJOUo1NXVoVThTb2Z2Vjd2V3Q4UDdCYzBrRFMwVGhUVTVpc1U4TDJodnU1VVdSQ3dwbWRKTApOSU9NaG5reDNLVkFrTWtQS2NXWWJnYWFvT2dRR1p4R3R5aW1hZGU4TTNRdUdvYWZDQmRLWXJHaFJFbUdYclR6CmRCVW1xZjg3a0R2VVpSaTdPWXdYMUNFUnk5ZzFmalRJRlI4aVM3cDdTQVQ4c2xNWGx0ZE82ZGZMQlM2RDFKbUoKYjFDclJTK2JlNk5GWWRGTkpUclVqZGJYYXNNRDdoTUt2TU9HNXZNY3VqSWRrT0Zjb0tva29iam9lZHAzeTI3SQovYkdvQVl3RzlhdTBxWWJGWHdvTmM3RFNYK1hGWnVGZHA5TlBGODhDQXdFQUFhT0IwakNCenpBT0JnTlZIUThCCkFmOEVCQU1DQmFBd0hRWURWUjBsQkJZd0ZBWUlLd1lCQlFVSEF3RUdDQ3NHQVFVRkJ3TUNNQXdHQTFVZEV3RUIKL3dRQ01BQXdId1lEVlIwakJCZ3dGb0FVTzM1RkNFM3hXWVJTRG4vaUE4RjQzL01CMkFNd2J3WURWUjBSQkdndwpab0lNYzJWdWRISjVMVzVuYVc1NGdoUnpaVzUwY25rdGJtZHBibmd1WkdWbVlYVnNkSUlZYzJWdWRISjVMVzVuCmFXNTRMbVJsWm1GMWJIUXVjM1pqZ2laelpXNTBjbmt0Ym1kcGJuZ3VaR1ZtWVhWc2RDNXpkbU11WTJ4MWMzUmwKY2k1c2IyTmhiREFOQmdrcWhraUc5dzBCQVFzRkFBT0NBUUVBaWtGVXdIbzU4V0VxNkJFMy96UDFhdGUxSWJmWQpPSTVvLzBwN0pEekRBajVMMkQxOGZJTllFVGdMRDYrSDh1ekhuSVNvc2NJQlphSWgyYlpPeUNrWTBQbFFEanIwCkdVczFudjJEU2JmQ2s4dlM2eHRaUUZkd0Uyb2lmYVlIbnNGaXhCL0ZaU1djNyt4UXZIdXAwREF1d0NyMmRXdW8KUUZZT1NtbGV6NGlTaXA1a2xrNEdWL2dBUHRnT1RVUWx6YlF5UzhSbjhJcnQ3TXdCN0pZV2pDRTJNemJiSXVQMAo1c0ZaMDVIenpsbzNEUmZWSHJGS2pPWkRSL0xGZnl5Tnc0c2NCSUo4TmFlbUh3TVA3b0NaSU1GY3F5MnduRDJ0ClIzZDZkWDVjdm9jd2ExckJVODB0LzVtaVdodTBwa1RrZXZFMEF2amRjK2FEOVh1b1VLUmN3cU5xNGc9PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
>   tls.key: LS0tLS1CRUdJTiBSU0EgUFJJVkFURSBLRVktLS0tLQpNSUlFcEFJQkFBS0NBUUVBOS92M0ZqZ09vNlNIb01yMkQ0MVVaMGtiYURSQzNDNEdhY0syZU1oa0NuUU5qRGdCCmZXYllETlFEK3NqMG5ubTZGVHhLaCs5WHU5YTN3L3NGelNRTkxST0ZOVG1LeFR3dmFHKzdsUlpFTENtWjBrczAKZzR5R2VUSGNwVUNReVE4cHhaaHVCcHFnNkJBWm5FYTNLS1pwMTd3emRDNGFocDhJRjBwaXNhRkVTWVpldFBOMApGU2FwL3p1UU85UmxHTHM1akJmVUlSSEwyRFYrTk1nVkh5Skx1bnRJQlB5eVV4ZVcxMDdwMThzRkxvUFVtWWx2ClVLdEZMNXQ3bzBWaDBVMGxPdFNOMXRkcXd3UHVFd3E4dzRibTh4eTZNaDJRNFZ5Z3FpU2h1T2g1Mm5mTGJzajkKc2FnQmpBYjFxN1NwaHNWZkNnMXpzTkpmNWNWbTRWMm4wMDhYendJREFRQUJBb0lCQVFDSVErQW1TVzloNUlyUwpoRFJwbjFOOTNlSTloRm9vK3ZGek5CZG9qMVRKbWJQSUZRNWNoaUs2Q2RhVis4N1BOanhXWnViZGcxdEdVRnB5ClNvR0psQUhaZnh4M2ZzTU9WbUFHbHo4UVVVZnNySDlsMndWa005ZkF5UEZoclBUaVJuN0JvVnowTEF1MitRSFoKcWRJRGVFNDR5YVhNZFhrRitHVk54d1lzYlYxRXVJaHJ5WStheHJ1NGpkZDNQNW82SUJIV3pkUklIVktzZDlSTwp1MHNIOXBWYmF6aUVQVzlNcGJsc29BaTNGU1RQVktUeU1iekNmSGJhd1lFWmVhNmU4M051bjNORWwrNThjYTVOClBJcnNOcXgvclRIQ2t0VjlqSEZqTzdGT2xYWWErNGdFM3NVMm10Vm9rbGJ3blovdnRoZEFzZ0FKMVBPQ3E2ajUKcW1ubE8rMkJBb0dCQVA5N1ZVWjMxazlYeHY4SFAvUDJ6eHVKYllIZWVveEc0Mmk5SHRqbzlvSngrMG50Wk8xNQpnV3pNTWR3K1ZCaVZUbnFEWnlzU0lrWTNna2g1K3VGVHo3Tk9iUUMwT2N3VUNEV2dYZEU1VG1DWjNVV2VIaWFICm1pN3YzRjNTMlQwVW81U1BoWDcyTHFZOWNHQzVzSzg0d2JNZEhpdlp4S1E3OHRQVGFrTkhVOXkvQW9HQkFQaDgKdlI2bnd1YWR1QzkzZHl2K3JOSTlQbU9CbnFabmVacGFzRTJQN2NLZGZPd0tMNlMwSVdWQnVnaDFnbkR1Y2pObApETnpMMlNVRlNpcDNxcHlGeHo3SVcxNGh4TEl2NzBaZjQxODFQdXJvQ1ViTXFoVG1uTlVVN044VW5jYm9IQ0lyCktrbHZkNUN2QTFJUzRlRmJsNE1vamN6amNicXpBMUNCMnlRUERianhBb0dCQUxWR0tJS2dveUtYRUs2QjBXSGsKWEoyWVRHZ2FtTytSbU9nSFVLenQxNE5GSnQwVW9VbFNybitvL3pQYjBjWERvdlNRNmhJSWd1TTVuYXFaU21hNQpGaVdPM3c3aDBpUzRqZjZtOUFweFUraDlKQ0N5aVlnakxVWmlrUVROaDdDc1JVa3k4TERlTXNsbnpLWUUrNVhJCmVzQUJTQmdySXppNUJKcENaeUtucUp4M0FvR0FkTTl1dC9KMUZLUWY2WEJuZlM4RFh2R2JXbnVjY08xRHBPUHMKN1FrejQ4RFU4TUQ1Rkp2NDl2aW0wME1xUnB4UTR3Z2x1OFc0RmtjZVRraGkwNkd2d0R1L2Q4aTRCbXV5TjRycgovOTJ2N2cyV0RzbzNTZ3YrdmN4UWJhM3JYWTNQYStDT3lHYTE5alhQZ2MyT2tiblV4N3RRclhoZUJqNFEyTSt5CmpJam5Fb0VDZ1lBMUpXY2xKVi9NTk9vTnRoVUtMbGx6YVNpWmF4cEtnaGZHNms5MzBWT2dLbWxXUXR2cTdiQTUKSW5aQlN5eWNSeTZrN00vR0M4NG44OHJ4MytIV0JWQVVjYzZ0YzI4OXF1NDVnWU5NTCtFZjY3ZjdydDVFblR2TgpUaWNpM280eFFxbTR6UWU4SHY5aEpYRCtoVy9KSUFzVzhENW9DZHJNbHBKcHVzMmZpSnNZYnc9PQotLS0tLUVORCBSU0EgUFJJVkFURSBLRVktLS0tLQo=
>   ca.crt: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURFVENDQWZtZ0F3SUJBZ0lRYjMxYkIwVUZML2k1N09SNGc3OGtLVEFOQmdrcWhraUc5dzBCQVFzRkFEQVQKTVJFd0R3WURWUVFERXdodVoybHVlQzFqWVRBZUZ3MHlOREE1TXpBd01ESTRORFphRncweU5UQTVNekF3TURJNApORFphTUJNeEVUQVBCZ05WQkFNVENHNW5hVzU0TFdOaE1JSUJJakFOQmdrcWhraUc5dzBCQVFFRkFBT0NBUThBCk1JSUJDZ0tDQVFFQW9sNkFZakNQakJPa2lyc3ROQkQyZGdRME1hRWttMkF5d0NNOStmNVIvdncvazFkdUR5U2YKcDNLWHg1bC9XaElCM0tiVjhSczB4bU5meU9mcnNQNFZXenljMzlNNkNXOWNWK21pTldhYTZrd3FITm9PMzdoQgowMHRFVDViVVBsczhqa3NOVzBLUGlCNi9VUkRkZU81bEJOaWhVMDArQmlXblUyUXRBKy95ZUZPajF6TXVoL0F5Ck8zTTlSYUlSRnd2dmpYdEprelBhRUhTL2N2Snk3b1I5ZUNXdXRJM2xTTXVnZ0pXcW14VGg5WGdpZ1J5OVZoOFoKbzJaMW4zMU9sSGZrZmIvd0pBYkZFcTRKMENqV1EzZ3NCckZmenZvZDFOaUlaUmk5U1J0d2lnaDZvWlJHWFJHaQpZZFJmMWk5OUVvS2FzN3pqSmhzYUVsaXBRcGJRU25kT3J3SURBUUFCbzJFd1h6QU9CZ05WSFE4QkFmOEVCQU1DCkFxUXdIUVlEVlIwbEJCWXdGQVlJS3dZQkJRVUhBd0VHQ0NzR0FRVUZCd01DTUE4R0ExVWRFd0VCL3dRRk1BTUIKQWY4d0hRWURWUjBPQkJZRUZEdCtSUWhOOFZtRVVnNS80Z1BCZU4vekFkZ0RNQTBHQ1NxR1NJYjNEUUVCQ3dVQQpBNElCQVFBMVY5NG1OZ043NWxKenJqTWFYbkNWRm8xQmMzb0w2bmtVcW95Sml5Nm12bXA5UTVuRHZZUHFkbjZZCmVVMGREdk9EVG9ZSGQxc2owWWpLM3F3Ti8rTUdic0M3cFNDZE9hNTB3cm81Z2pOcXAyQysxZWxIbjdMR2F0Y1UKdWUxbnZFTjJVRW5jejRxTTJ1VndFUlgrb3dJQWR6OFFpSVk0UTBvcUFMb1BVRXgxVVJiaHdZTDJmYTBqNzRqRwpLY0k1WGZ2Z001b0QzWnZzT3pNWGkwL09GNTJXa0ozRURtUnFpUHRMQVBEOTNYaGpSNER0V2J2VnQ3UmxuUXEzCnlGMmM1S2p1eG5QdHpFeGVLejV3emlPR2lxWmpVN1Rqc3Vja0xQYndyZ2lYcVoyNXVhSlY5YXJuUU9NMXU5T3MKbTJnRjBPMlFvemg4ZU5vVjU1OVNOWmFyMVFndgotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==
8883c8848
<   postgres-password: "ekNvRlZYTENucg=="
---
>   postgres-password: "ODd1MDZpdHlIZQ=="
9644c9609
<       redis: "redis://@sentry-sentry-redis-master:6379/0"
---
>       redis: "redis://:@sentry-sentry-redis-master:6379"
9689c9654,9660
<     # This is configured in the sentry.conf.py as that has support for environment variables.
---
>     redis.clusters:
>       default:
>         hosts:
>           0:
>             host: "sentry-sentry-redis-master"
>             port: 6379
>             password: ""
9745,9763d9715
<     # Redis #
<     #########
<   
<     # Generic Redis configuration used as defaults for various things including:
<     # Buffers, Quotas, TSDB
<     SENTRY_OPTIONS["redis.clusters"] = {
<       "default": {
<         "hosts": {
<           0: {
<             "host": "sentry-sentry-redis-master",
<             "password": os.environ.get("REDIS_PASSWORD", ""),
<             "port": "6379",
<             "db": "0"
<           }
<         }
<       }
<     }
<   
<     #########
10130c10082
<     REDIS_PASSWORD = env("REDIS_PASSWORD", "")
---
>     REDIS_PASSWORD = ""
10132d10083
<     REDIS_SSL = "false"
10882c10833
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
10962c10913
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
11062c11013
<         checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>         checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf
11150c11101
<         checksum/config.yaml: 4c84a374db5b08752b0f7575892f7f0ec90fd600a5623ca6511f126cc487dc15
---
>         checksum/config.yaml: 4bcb4f66a67634c55973c61cce0c2439ea8d9357f5f6fe5907f9341c99223a20
11170,11171d11120
<         - name: REDIS_PORT
<           value:  "6379"
12378c12327
<             checksum/config.yaml: f5a7395cf0a67c5f35414f7502bc2c08865bbfbc6c8a0608aa8493a6c20132c0
---
>             checksum/config.yaml: 2700c1b83a8f527df427ca86df3897d4d823f86b13f1d21d796ea785f82777bf

I don't see any actual difference that can cause issues

…asswords are defined

nadecancode · 2024-09-30T06:13:27Z

@Mokto, it seems like my changes have passed the pipeline. May you take a look? Thank you :)

… broke S3 existing secret (from commit 0b7a7b4)

…ing secret (from commit 0b7a7b4) (#1499) Co-authored-by: Damien <maitredede@users.noreply.github.com>

frank-m and others added 2 commits September 29, 2024 00:19

fix: resolve cherry-pick conflict

32b4476

nadecancode force-pushed the develop branch from 06fbf27 to 32b4476 Compare September 29, 2024 07:20

nadecancode added 2 commits September 29, 2024 00:36

fix: address linting

6727be1

fix: make relay respect externalRedis.existingSecret

06885da

nadecancode mentioned this pull request Sep 29, 2024

Improve Redis Password Handling in Helm Chart #1480

Closed

nadecancode added 2 commits September 29, 2024 01:38

style: space between quote and pipe

b894352

fix: correct redis url in relay config

274d1ea

nadecancode changed the title ~~Reintroduce "Extend Redis functionality"~~ feat: reintroduce "Extend Redis functionality" Sep 29, 2024

nadecancode added 2 commits September 29, 2024 10:21

fix: don't generate redis secret reference if password and existingSe…

0938565

…cret are empty

fix: don't generate redis secret reference if password and existingSe…

70d0f48

…cret are empty (another location)

nadecancode added 4 commits September 29, 2024 11:07

fix: respect subchart's secret path to be consistent with generated s…

13aff46

…ubchart credential and referenced credential in Sentry deployments

fix: don't render password if plain text password is empty

6b7ed50

fix: improve password rendering

2ecaaed

fix: respect original snuba redis database value

7adbcc3

nadecancode added 6 commits September 29, 2024 18:20

fix: correct more password rendering

c5fd21e

fix: sentry.redis.password should not return any value if neither p…

bbd6dbd

…asswords are defined

fix: Fix SENTRY_SSL being rendered as non-python value

105929a

fix: remove the need to specify brokerUrl in values if using Redis

e20c274

fix: remove the brokerUrl reference

0db2375

fix: move redis variables to correct location

0cf4e59

fix: remove comments

4b8647e

Mokto approved these changes Sep 30, 2024

View reviewed changes

Mokto merged commit 0b7a7b4 into sentry-kubernetes:develop Sep 30, 2024
2 checks passed

Mokto mentioned this pull request Sep 30, 2024

chore: release develop #1497

Merged

maitredede added a commit to maitredede/sentry-kubernetes-charts that referenced this pull request Sep 30, 2024

fix: reintroduced "Extend Redis functionality" (sentry-kubernetes#1492)…

ee0200b

… broke S3 existing secret (from commit 0b7a7b4)

Mokto pushed a commit that referenced this pull request Oct 1, 2024

fix: reintroduced "Extend Redis functionality" (#1492) broke S3 exist…

3eb75ef

…ing secret (from commit 0b7a7b4) (#1499) Co-authored-by: Damien <maitredede@users.noreply.github.com>

Mokto mentioned this pull request Oct 1, 2024

chore: release develop #1502

Merged

This was referenced Oct 15, 2024

fix: external redis functionality #1547

Closed

fix: external redis functionality for relay #1548

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: reintroduce "Extend Redis functionality" #1492

feat: reintroduce "Extend Redis functionality" #1492

nadecancode commented Sep 29, 2024 •

edited

Loading

nadecancode commented Sep 29, 2024 •

edited

Loading

patsevanton commented Sep 29, 2024

nadecancode commented Sep 29, 2024

nadecancode commented Sep 30, 2024

nadecancode commented Sep 30, 2024 •

edited

Loading

feat: reintroduce "Extend Redis functionality" #1492

feat: reintroduce "Extend Redis functionality" #1492

Conversation

nadecancode commented Sep 29, 2024 • edited Loading

nadecancode commented Sep 29, 2024 • edited Loading

patsevanton commented Sep 29, 2024

nadecancode commented Sep 29, 2024

nadecancode commented Sep 30, 2024

nadecancode commented Sep 30, 2024 • edited Loading

nadecancode commented Sep 29, 2024 •

edited

Loading

nadecancode commented Sep 29, 2024 •

edited

Loading

nadecancode commented Sep 30, 2024 •

edited

Loading