Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct argument order of consumers #1522

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: correct argument order of consumers #1522

merged 1 commit into from
Oct 8, 2024

Conversation

YannikSc
Copy link
Contributor

@YannikSc YannikSc commented Oct 8, 2024

Heya, I noticed an error message after upgrading sentry in some of my consumers

Usage: sentry run consumer [OPTIONS] CONSUMER_NAME [CONSUMER_ARGS]...
Try 'sentry run consumer --help' for help.

Error: No such option: --max-batch-size

after checking the template for it, I found a commit that already took care of a similar issue in the past (2861efa).

However there were some places and arguments missing in the move, so here we got!

Mokto
Mokto approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Mokto Mokto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mokto Mokto merged commit 6236a74 into sentry-kubernetes:develop Oct 8, 2024
2 checks passed
@Mokto Mokto mentioned this pull request Oct 8, 2024
Merged
@YannikSc
Copy link
Contributor Author

YannikSc commented Oct 8, 2024

Well, that was very fast. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mokto Mokto Mokto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YannikSc @Mokto