New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: offset-reset in ds #1533

Merged

Mokto merged 1 commit into sentry-kubernetes:develop from paulDashkevich:upd_develop_for_new_image

Oct 13, 2024

Contributor

paulDashkevich commented Oct 13, 2024

No description provided.


          feat: offset-reset in ds

7d5d752

Contributor

patsevanton commented Oct 13, 2024 •

edited

Loading

I think need add comment with noStrictOffsetReset values.yaml

Contributor Author

paulDashkevich commented Oct 13, 2024

Yes, Anton. I'd remembered that after commit.

paulDashkevich force-pushed the upd_develop_for_new_image branch from fc692f3 to 7d5d752 Compare

October 13, 2024 08:59

Mokto approved these changes

View reviewed changes

Mokto merged commit 0e3ef2d into sentry-kubernetes:develop

4 checks passed

Mokto mentioned this pull request

chore: release develop #1534

Merged

Contributor

adonskoy commented Oct 13, 2024

It would be nice if you added --strict-offset-reset / --no-strict-offset-reset and --auto-offset-reset for all missing places

--strict-offset-reset / --no-strict-offset-reset is missing in:

deployment-sentry-ingest-monitors
deployment-sentry-ingest-occurrences
deployment-sentry-ingest-profiles
deployment-sentry-ingest-replay-recordings
deployment-sentry-billing-metrics-consumer
deployment-sentry-metrics-consumer
deployment-sentry-subscription-consumer-events
deployment-sentry-subscription-consumer-generic-metrics
deployment-sentry-subscription-consumer-metrics
deployment-sentry-subscription-consumer-transactions

--auto-offset-reset is missing in:

deployment-sentry-ingest-consumer-attachments
deployment-sentry-ingest-consumer-events
deployment-sentry-ingest-monitors
deployment-sentry-ingest-occurrences
deployment-sentry-ingest-profiles
deployment-sentry-ingest-replay-recordings
deployment-sentry-ingest-consumer-transactions
deployment-sentry-billing-metrics-consumer
deployment-sentry-generic-metrics-consumer
deployment-sentry-metrics-consumer
deployment-sentry-post-process-forwarder-errors
deployment-sentry-post-process-forwarder-issue-platform
deployment-sentry-post-process-forwarder-transactions
deployment-sentry-subscription-consumer-events
deployment-sentry-subscription-consumer-generic-metrics
deployment-sentry-subscription-consumer-metrics
deployment-sentry-subscription-consumer-transactions

Contributor

adonskoy commented Oct 13, 2024

Oh, it was already merged. I'll make a separate PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet