Add configuration for noStrictOffsetReset #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! You still have to rebase |
|
👋 Hi, @pyama86, |
…r noStrictOffsetReset Introduce a new configuration option `noStrictOffsetReset` in the Snuba replacer deployment template and values file. This allows users to optionally disable strict offset reset behavior by setting `noStrictOffsetReset` to true in the `values.yaml` file. This change provides more flexibility in handling offset resets, which can be useful in certain deployment scenarios where strict offset management is not required or desired.
pyama86
force-pushed
the
no-strict-replacer
branch
from
6632c96 to
3c212a1
Compare
|
@Mokto |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new configuration option
noStrictOffsetResetin the Snuba replacer deployment template and values file. This allows users to optionally disable strict offset reset behavior by settingnoStrictOffsetResetto true in thevalues.yamlfile. This change provides more flexibility in handling offset resets, which can be useful in certain deployment scenarios where strict offset management is not required or desired.