Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving dependencies on job failures #33

Closed
wr0ngway opened this issue Oct 8, 2013 · 2 comments
Closed

Resolving dependencies on job failures #33

wr0ngway opened this issue Oct 8, 2013 · 2 comments

Comments

@wr0ngway
Copy link

wr0ngway commented Oct 8, 2013

From what I can tell, if a job fails, none of its dependent jobs get triggered. Is this expected behavior? If so, it would be nice if the behavior could be configured so that I can depend on a job completing, be it successful or not.

@myronmarston
Copy link
Contributor

It's 100% the way dependencies were designed to work. The use case we had was multiple jobs that operate on an external resource in sequence. Job B depends on Job A putting that resource into a particular state. If Job A fails, job B can't proceed because it's unknown if the resource is in the state it requires.

What is your use case? Dependencies may not be the right tool for it. Alternately, you can use a middleware to undepend jobs on failure, in order to get the behavior you're looking for

@wr0ngway
Copy link
Author

wr0ngway commented Oct 8, 2013

Thats fine, just wanted to make sure I wasn't missing something, I have something in my middleware to remove dependencies on a failure to work around this.

We are using the dependency mechanism to implement a poor-mans job concurrency, and completion rather than success is the important event for determining if a dependent job can run. Once #27 is completed, we'll probably switch to that instead.

@wr0ngway wr0ngway closed this as completed Oct 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants