Transaction signing #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
added 2 commits
September 10, 2023 22:23
added 5 commits
September 18, 2023 18:59
…acro due to lifetime issues when deserializing
* current state * initial * initial * add to changelog * impl LedgerObject trait * remove .DS_Store * add documentation * cargo fix * add Default trait to FlagCollection * refactoring of models * fix serde tests * fix serde tests * Delete src/models/.DS_Store * remove dafault_none * resolve comments
LimpidCrypto
added a commit
that referenced
this pull request
Aug 31, 2024
* move BinarySerializer and BinaryParser * add STObject * current state of txn signing * current state of sign * current state of sign * use String instead of Cow<'a, str> for structs using serde_with_tag macro due to lifetime issues when deserializing * utilize Cow for models * utilize Cow for models * cargo fmt * add simple test * add devcontainer * fix async client tests * fix github workflow * fix tests with --all-features * fix --no-default-features tests with embedded-ws * try fix colliding embebedded-websocket feature with dep: syntax * fix ambiguous name error * Revise Models (#74) * current state * initial * initial * add to changelog * impl LedgerObject trait * remove .DS_Store * add documentation * cargo fix * add Default trait to FlagCollection * refactoring of models * fix serde tests * fix serde tests * Delete src/models/.DS_Store * remove dafault_none * resolve comments * revise dependencies * remove old clients * add new clients * add codec for std embedded websocket * move websocket exceptions * add WebsocketBase * add Client and AsyncClient traits * add XRPLWebsocketIO as standardized trait * adjust clients mod * add XRPLResponse * revise the Request trait to have methods to get a resut models common fields * cargo fmt * add get_random_id utility function * add xrpl testnet uri * revise the tests to work with the changes * error handling * improve testing * implement websocket client request * implement websocket client request for embedded websocket * update rand trying to get rid of cargo check: OsRng: rand_core::RngCore is not satisfied error * fix github workflow build and tests * fix github workflow build and tests * run linters * add json rpc client * add json rpc for std and tests * cargo fmt * add pre-commit test with json-rpc-std * cargo fmt * cargo fix * improve client code * refactor features * fix tungstenite example * fix clients * fix client tests * fix tests * rename features in github workflow * add transaction auto filling as in #76 (#80) * current state of txn signing * current state of sign * current state of sign * add simple test * resolve errors caused by updating branch * resolve errors caused by updating branch * add autofill_and_sign * make tx signing work * improve sign test * handle unwraps * add autofill_and_sign * add sign and submit * fix errors caused by solving merge conflicts * rename SerializedDict and SerializedList to STObject and STArray * rename SerializedDict and SerializedList to STObject and STArray * handle unwraps * fix tests * fix tests * fix tests * add multisigning * add multisigning * fix tests * fix tests --------- Co-authored-by: LimpidCrypto <info@limpidcrypto.de>
LimpidCrypto
added a commit
that referenced
this pull request
Oct 6, 2024
* move BinarySerializer and BinaryParser * add STObject * current state of txn signing * current state of sign * current state of sign * use String instead of Cow<'a, str> for structs using serde_with_tag macro due to lifetime issues when deserializing * utilize Cow for models * utilize Cow for models * cargo fmt * add simple test * add devcontainer * fix async client tests * fix github workflow * fix tests with --all-features * fix --no-default-features tests with embedded-ws * try fix colliding embebedded-websocket feature with dep: syntax * fix ambiguous name error * Revise Models (#74) * current state * initial * initial * add to changelog * impl LedgerObject trait * remove .DS_Store * add documentation * cargo fix * add Default trait to FlagCollection * refactoring of models * fix serde tests * fix serde tests * Delete src/models/.DS_Store * remove dafault_none * resolve comments * revise dependencies * remove old clients * add new clients * add codec for std embedded websocket * move websocket exceptions * add WebsocketBase * add Client and AsyncClient traits * add XRPLWebsocketIO as standardized trait * adjust clients mod * add XRPLResponse * revise the Request trait to have methods to get a resut models common fields * cargo fmt * add get_random_id utility function * add xrpl testnet uri * revise the tests to work with the changes * error handling * improve testing * implement websocket client request * implement websocket client request for embedded websocket * update rand trying to get rid of cargo check: OsRng: rand_core::RngCore is not satisfied error * fix github workflow build and tests * fix github workflow build and tests * run linters * add json rpc client * add json rpc for std and tests * cargo fmt * add pre-commit test with json-rpc-std * cargo fmt * cargo fix * improve client code * refactor features * fix tungstenite example * fix clients * fix client tests * fix tests * rename features in github workflow * add transaction auto filling as in #76 (#80) * current state of txn signing * current state of sign * current state of sign * add simple test * resolve errors caused by updating branch * resolve errors caused by updating branch * add autofill_and_sign * make tx signing work * improve sign test * handle unwraps * add autofill_and_sign * add sign and submit * fix errors caused by solving merge conflicts * rename SerializedDict and SerializedList to STObject and STArray * rename SerializedDict and SerializedList to STObject and STArray * handle unwraps * fix tests * fix tests * fix tests * add multisigning * add multisigning * fix tests * fix tests --------- Co-authored-by: LimpidCrypto <info@limpidcrypto.de>
LimpidCrypto
added a commit
that referenced
this pull request
Oct 6, 2024
* move BinarySerializer and BinaryParser * add STObject * current state of txn signing * current state of sign * current state of sign * use String instead of Cow<'a, str> for structs using serde_with_tag macro due to lifetime issues when deserializing * utilize Cow for models * utilize Cow for models * cargo fmt * add simple test * add devcontainer * fix async client tests * fix github workflow * fix tests with --all-features * fix --no-default-features tests with embedded-ws * try fix colliding embebedded-websocket feature with dep: syntax * fix ambiguous name error * Revise Models (#74) * current state * initial * initial * add to changelog * impl LedgerObject trait * remove .DS_Store * add documentation * cargo fix * add Default trait to FlagCollection * refactoring of models * fix serde tests * fix serde tests * Delete src/models/.DS_Store * remove dafault_none * resolve comments * revise dependencies * remove old clients * add new clients * add codec for std embedded websocket * move websocket exceptions * add WebsocketBase * add Client and AsyncClient traits * add XRPLWebsocketIO as standardized trait * adjust clients mod * add XRPLResponse * revise the Request trait to have methods to get a resut models common fields * cargo fmt * add get_random_id utility function * add xrpl testnet uri * revise the tests to work with the changes * error handling * improve testing * implement websocket client request * implement websocket client request for embedded websocket * update rand trying to get rid of cargo check: OsRng: rand_core::RngCore is not satisfied error * fix github workflow build and tests * fix github workflow build and tests * run linters * add json rpc client * add json rpc for std and tests * cargo fmt * add pre-commit test with json-rpc-std * cargo fmt * cargo fix * improve client code * refactor features * fix tungstenite example * fix clients * fix client tests * fix tests * rename features in github workflow * add transaction auto filling as in #76 (#80) * current state of txn signing * current state of sign * current state of sign * add simple test * resolve errors caused by updating branch * resolve errors caused by updating branch * add autofill_and_sign * make tx signing work * improve sign test * handle unwraps * add autofill_and_sign * add sign and submit * fix errors caused by solving merge conflicts * rename SerializedDict and SerializedList to STObject and STArray * rename SerializedDict and SerializedList to STObject and STArray * handle unwraps * fix tests * fix tests * fix tests * add multisigning * add multisigning * fix tests * fix tests --------- Co-authored-by: LimpidCrypto <info@limpidcrypto.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adds async transaction signing.
Type of Change
Tasks
auto_fill_txn#76signmethodDeserializelifetime issues