Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type declarations is not included inside published npm package #1183

Closed
ngoclong19 opened this issue Oct 23, 2022 · 2 comments · Fixed by #1185
Closed

Type declarations is not included inside published npm package #1183

ngoclong19 opened this issue Oct 23, 2022 · 2 comments · Fixed by #1185
Labels

Comments

@ngoclong19
Copy link
Contributor

What you are doing?

Trying to get type hint in VS Code and it does not work.

'use strict';
/** @type {import('sequelize-cli').Migration} */
module.exports = {
  async up(queryInterface, Sequelize) {

What do you expect to happen?

I expect queryInterface and Sequelize are properly typed.

What is actually happening?

The two parameters has type any.

In folder node_modules/sequelize-cli, the file types.d.ts is missing.
I also checked the download tarbal from npmjs.org.

Dialect: any
Database version: XXX
Sequelize CLI version: 6.5.1
Sequelize version: 6.25.3

@WikiRik
Copy link
Member

WikiRik commented Oct 23, 2022

A PR for this is welcome, but this is on our list to fix in the next major release (v7) together with other TypeScript related improvements.

@github-actions
Copy link

🎉 This issue has been resolved in version 6.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants