forked from coopernurse/node-pool
-
Notifications
You must be signed in to change notification settings - Fork 17
forked from coopernurse/node-pool
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destroying inactive resources can cause unhandled promise rejection #53
Labels
bug
Something isn't working
Comments
Thanks for reporting this, I have taken a look at this. When the The simplest way to solve this would be to convert the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I wanted to share a possible bug. If
destroy
method passed toPool
constructor is async, then its rejection might cause an unhandled promise rejection, for example in idle timer (it doesn't seem to await resource destruction). Here's a test that demonstrates the behavior (it fails with an unhandled rejection)Thanks for looking at this,
The text was updated successfully, but these errors were encountered: