Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third-party scripts (Feature) #5

Open
bengourley opened this issue Mar 22, 2012 · 1 comment
Open

Third-party scripts (Feature) #5

bengourley opened this issue Mar 22, 2012 · 1 comment

Comments

@bengourley
Copy link
Contributor

It would be nice to have a feature in compact that lets you reference third party scripts.. e.g jQuery on Google's CDN, Google Maps API, various share widgets (Twitter, +1, Facebook).

e.g:

compact.addNamespace('find-us')
    .addThirdPartyJs('http://maps.google.com/maps/api/js?sensor=true')
    .addJs('/js/my-map.js');

Output:

<script src='http://maps.google.com/maps/api/js?sensor=true'></script>
<script src="/js/compact/find-us.js"></script>

Similar functionality is easily achievable with Jade template inheritance, but I think it would be better if all of the frontend JS was organised in one place. What do you think?

@serby
Copy link
Owner

serby commented Mar 23, 2012

I think that addJs could be extended to take urls to compress.

But I'm a not sure about of making compact a javascript loader. Either I need to change the name to a synonym of 'Load' or we create another module that extends compress and but helps manage all your JavaScript.

jsLoader.addRemoteNamespace('map')
    .addJs('http://maps.google.com/maps/api/js?sensor=true', { failoverToLocal: true })

jsLoader.addNamespace('find-us')
    .addJs('/js/my-map.js');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants