-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cargo features need to be additive #543
Comments
No longer urgent because serde_derive does not use syntex anymore, so the problem has not gotten worse. |
We may be done here by just dropping Syntex. The |
Indeed I can confirm that the only feature breaking from the additiveness is |
Filing here for lack of a better place to file it. This affects all of serde_codegen, serde_codegen_internals, aster and quasi.
Cargo features are supposed to be additive. The
with-syntex
features across the ecosystem are not additive because they remove the libsyntax-based methods. This results in breakage like adding a dependency on serde_derive can break existing code that uses aster without syntex.We need to move to additive features like:
where you can build with both syntex and libsyntax simultaneously if necessary.
The text was updated successfully, but these errors were encountered: