Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom spinner #17

Closed
seregazhuk opened this issue Oct 10, 2019 · 3 comments · Fixed by #19
Closed

Implement custom spinner #17

seregazhuk opened this issue Oct 10, 2019 · 3 comments · Fixed by #19
Assignees
Labels
enhancement New feature or request

Comments

@seregazhuk
Copy link
Owner

We need to decouple from alecrabbit/php-console-spinner. It has a lot of dependencies, for example under the hood it requires laravel container 6.0 and thus cannot be installed on the latest laravel version.

The logic to render a spinner is pretty simple and can be easily implemented right here inside the library.

@seregazhuk seregazhuk self-assigned this Oct 10, 2019
@seregazhuk seregazhuk added the enhancement New feature or request label Oct 10, 2019
@alecrabbit
Copy link

alecrabbit commented Oct 20, 2019

Hi @seregazhuk!
It will be a pleasure for me if you'll consider to return to use my package 😃
I mean new one - alecrabbit/php-cli-snake
it has literally zero dependencies, but still offers some useful features

@seregazhuk
Copy link
Owner Author

Hi @alecrabbit Thank you! That's great 👍 I'll look through it.

@seregazhuk
Copy link
Owner Author

@alecrabbit done! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants