Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Want v8 support in serenity-voice-model #2943

Open
FelixMcFelix opened this issue Aug 16, 2024 · 0 comments
Open

Want v8 support in serenity-voice-model #2943

FelixMcFelix opened this issue Aug 16, 2024 · 0 comments
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. voice Related to the `voice` module and `serenity_voice_model` crate.

Comments

@FelixMcFelix
Copy link
Member

FelixMcFelix commented Aug 16, 2024 •
edited
Loading

Voice gateway version 8 includes several breaking changes to message formats:

  • All received (server-to-client) messages will include a seq integer value.
  • Heartbeat payload are changing from int -> struct { t: int } on the wire.
  • Resume requests will include a seq_ack field, corresponding to the last seen seq at a client.

Making these changes is not pressing -- we're explicitly advertising v4 gateway support, so we do have some mileage as that pathway is not being deprecated as yet. At most this enables extra functionality around gateway message replay -- see serenity-rs/songbird#247.
@FelixMcFelix FelixMcFelix added enhancement An improvement to Serenity. voice Related to the `voice` module and `serenity_voice_model` crate. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users enhancement An improvement to Serenity. voice Related to the `voice` module and `serenity_voice_model` crate.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FelixMcFelix