Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe keyword parameters not completely renamed #126

Closed
MarkkuTurunen opened this issue Aug 26, 2016 · 7 comments
Closed

Swipe keyword parameters not completely renamed #126

MarkkuTurunen opened this issue Aug 26, 2016 · 7 comments

Comments

@MarkkuTurunen
Copy link

Parameters offset_x and offset_y are not used. driver.swipe() receives parameters by their old names end_x and end_y.

@serhatbolsu
Copy link
Owner

please check my comment on #125

@smaspe
Copy link
Contributor

smaspe commented Aug 26, 2016

I have read your comment and checked the code, I don't understand why this issue is closed. Trying to use Swipe results in a crash saying 'end_x' is not defined, obviously.

@serhatbolsu
Copy link
Owner

@smaspe you can get the master code right now, issue is fixed on master

@smaspe
Copy link
Contributor

smaspe commented Aug 27, 2016

@serhatbolsu thanks, but no thanks. Last time I updated, albeit to a released version, I got this regression packaged with it. So I will not get the current code from master. Not to mention it would require a significant change in the way the rest of the team uses the test suites (we are using pip to install all the dependencies, switching to getting the code is far from ideal). I'll just apply the fix locally, add a patch in the install procedure, and wait for the next release. And test it, too, before making the update.

@smaspe
Copy link
Contributor

smaspe commented Aug 27, 2016

Also, I don't understand why this issue is closed (given that it is present on the latest release.)

@MarkkuTurunen
Copy link
Author

@serhatbolsu It is good that this has been fixed in the master and thus it will be available in the next release. Also in our case we stick to published releases and we do not fetch a snapshot from master.

@smaspe
Copy link
Contributor

smaspe commented Aug 29, 2016

@serhatbolsu thanks for the release!

@MarkkuTurunen if you have not seen, there just was a new release addressing specifically that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants