Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js v6.0.0 - upgrade nan #772

Closed
ericogr opened this issue Apr 30, 2016 · 5 comments
Closed

Node.js v6.0.0 - upgrade nan #772

ericogr opened this issue Apr 30, 2016 · 5 comments

Comments

@ericogr
Copy link

ericogr commented Apr 30, 2016

Operating System and Hardware: Xubuntu 16.04LTS 64 bit, i7-4790K, 16GB RAM, kernel 4.4.0-21-generic
NodeJS Version: v6.0.0 npm 3.8.6
Serialport version: 3.0.0
Python Version: 2.7.11+

Actual behavior

Deprecated message

Steps and/or code to reproduce the issue

$ node

> var SerialPort = require("serialport").SerialPort;

(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x9bf71ac9fa9 #0#
1: .node [module.js:568] [pc=0x3a0d76bb6b04](this=0x274bed09fa39 <an Object with map 0x234ea4623371>#1#,module=0x274bed1720c9 <a Module with map 0x234ea4627361>#2#,filename=0x274bed171e61 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
2: load [module.js:456] [pc=0x3a0d76b99f72](this=0x274bed1720c9 <a Module with map 0x234ea4627361>#2#,filename=0x274bed171e61 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x3a0d76b99a9d](this=0x9bf71a04189 ,module=0x274bed1720c9 <a Module with map 0x234ea4627361>#2#,filename=0x274bed171e61 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
4: _load [module.js:407] [pc=0x3a0d76b96422](this=0x274bed09f541 <JS Function Module %28SharedFunctionInfo 0x3e0a9ad82639%29>#3#,request=0x274bed171241 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node>,parent=0x274bed163501 <a Module with map 0x234ea4627361>#4#,isMain=0x9bf71a04299 <false)
5: require [module.js:466] [pc=0x3a0d76b95e53](this=0x274bed163501 <a Module with map 0x234ea4627361>#4#,path=0x274bed171241 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
6: require(aka require) [internal/module.js:20] [pc=0x3a0d76b95b86](this=0x9bf71a04189 ,path=0x274bed171241 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
7: bindings [/tmp/serialtest/node_modules/bindings/bindings.js:76] [pc=0x3a0d76bb27b6](this=0x9bf71ae8be9 #5#,opts=0x3e0a9add9201 <String[15]: serialport.node)
8: /* anonymous _/ [/tmp/serialtest/node_modules/serialport/lib/bindings.js:3] [pc=0x3a0d76bb114e](this=0x274bed15d421 <an Object with map 0x1dc73e207bc9>#6#,exports=0x274bed15d421 <an Object with map 0x1dc73e207bc9>#6#,require=0x274bed15e9f1 <JS Function require %28SharedFunctionInfo 0x3e0a9ad93441%29>#7#,module=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,__filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js>,__dirname=0x274bed15e989 <String[43]: /tmp/serialtest/node_modules/serialport/lib)
9: _compile [module.js:541] [pc=0x3a0d76b9e504](this=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,content=0x274bed15e009 <String[784]:)('serialport.node');\nvar listUnix = require('./list-unix');\n\nvar linux = process.platform !== 'win32' && process.platform !== 'darwin';\n\nfunction listLinux(callback) {\n callback = callback || function(err) {\n if (err) { this.emit('error', err) }\n }.bind(this);\n return listUnix(callback);\n};\n\nvar platformOptions = {};\nif (process.platform !== 'win32') {\n platformOptions = {\n vmin: 1,\n vtime: 0\n };\n}\n\nmodule.exports = {\n close: bindings.close,\n drain: bindings.drain,\n flush: bindings.flush,\n list: linux ? listLinux : bindings.list,\n open: bindings.open,\n SerialportPoller: bindings.SerialportPoller,\n set: bindings.set,\n update: bindings.update,\n write: bindings.write,\n platformOptions: platformOptions\n};\n>,filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js>)
10: .js [module.js:550] [pc=0x3a0d76b9ac8b](this=0x274bed09fa39 <an Object with map 0x234ea4623371>#1#,module=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js)
11: load [module.js:456] [pc=0x3a0d76b99f72](this=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js)
12: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x3a0d76b99a9d](this=0x9bf71a04189 ,module=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js)
13: load [module.js:407] [pc=0x3a0d76b96422](this=0x274bed09f541 <JS Function Module %28SharedFunctionInfo 0x3e0a9ad82639%29>#3#,request=0x3e0a9adc0799 <String[10]: ./bindings>,parent=0x274bed104101 <a Module with map 0x234ea4627361>#9#,isMain=0x9bf71a04299 <false)
14: require [module.js:466] [pc=0x3a0d76b95e53](this=0x274bed104101 <a Module with map 0x234ea4627361>#9#,path=0x3e0a9adc0799 <String[10]: ./bindings)
15: require(aka require) [internal/module.js:20] [pc=0x3a0d76b95b86](this=0x9bf71a04189 ,path=0x3e0a9adc0799 <String[10]: ./bindings)
16: /
anonymous _/ [/tmp/serialtest/node_modules/serialport/lib/serialport.js:16] [pc=0x3a0d76b9ebee](this=0x274bed104189 <an Object with map 0x1dc73e207bc9>#10#,exports=0x274bed104189 <an Object with map 0x1dc73e207bc9>#10#,require=0x274bed10c411 <JS Function require %28SharedFunctionInfo 0x3e0a9ad93441%29>#11#,module=0x274bed104101 <a Module with map 0x234ea4627361>#9#,__filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js>,__dirname=0x274bed10c3a9 <String[43]: /tmp/serialtest/node_modules/serialport/lib)
17: _compile [module.js:541] [pc=0x3a0d76b9e504](this=0x274bed104101 <a Module with map 0x234ea4627361>#9#,content=0x274bed104f79 <Very long string[13443]>#12#,filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js)
18: .js [module.js:550] [pc=0x3a0d76b9ac8b](this=0x274bed09fa39 <an Object with map 0x234ea4623371>#1#,module=0x274bed104101 <a Module with map 0x234ea4627361>#9#,filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js)
19: load [module.js:456] [pc=0x3a0d76b99f72](this=0x274bed104101 <a Module with map 0x234ea4627361>#9#,filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js)
20: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x3a0d76b99a9d](this=0x9bf71a04189 ,module=0x274bed104101 <a Module with map 0x234ea4627361>#9#,filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js)
21: load [module.js:407] [pc=0x3a0d76b96422](this=0x274bed09f541 <JS Function Module %28SharedFunctionInfo 0x3e0a9ad82639%29>#3#,request=0x3e0a9adb9389 <String[10]: serialport>,parent=0x274bed0afd79 <a Module with map 0x234ea4627361>#13#,isMain=0x9bf71a04299 <false)
22: require [module.js:466] [pc=0x3a0d76b95e53](this=0x274bed0afd79 <a Module with map 0x234ea4627361>#13#,path=0x3e0a9adb9389 <String[10]: serialport)
23: require(aka require) [internal/module.js:20] [pc=0x3a0d76b95b86](this=0x9bf71a04189 ,path=0x3e0a9adb9389 <String[10]: serialport)
24: /
anonymous _/ [repl:1] [pc=0x3a0d76b94cf6](this=0x9bf71ae8be9 #5#)
28: defaultEval [repl.js:272] [pc=0x3a0d76b94200](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,code=0x274bed0f7fc9 <String[51]: var SerialPort = require%28"serialport"%29.SerialPort;n>,context=0x9bf71ae8be9 #5#,file=0x9bf71ad7891 <String[4]: repl>,cb=0x274bed0f73a1 <JS Function finish %28SharedFunctionInfo 0x3e0a9adb6fc9%29>#15#)
29: bound(aka bound) [domain.js:280] [pc=0x3a0d76b92f2e](this=0x9bf71a04189 ,this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,self=0x274bed0ab979 <a Domain with map 0x234ea4625fc9>#16#,cb=0x274bed0ab891 <JS Function defaultEval %28SharedFunctionInfo 0x3e0a9ad8db71%29>#17#,fnargs=0x274bed0f8021 <an Arguments with map 0x1dc73e20a509>#18#)
30: eval(aka runBound) [domain.js:293] [pc=0x3a0d76b92d32](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#)
31: arguments adaptor frame: 4->0
32: /
anonymous */ [repl.js:441] [pc=0x3a0d76b9061e](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,cmd=0x274bed0f60d9 <String[50]: var SerialPort = require%28"serialport"%29.SerialPort;)
33: emitOne(aka emitOne) [events.js:101] [pc=0x3a0d76b84139](this=0x9bf71a04189 ,handler=0x274bed0cee91 <JS Array[2]>#19#,isFn=0x9bf71a04299 ,self=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,arg1=0x274bed0f60d9 <String[50]: var SerialPort = require%28"serialport"%29.SerialPort;)
34: emit [events.js:188] [pc=0x3a0d76b22bea](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,type=0x9bf71a89199 <String[4]: line)
35: arguments adaptor frame: 2->1
36: _onLine [readline.js:219] [pc=0x3a0d76b8fb6d](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,line=0x274bed0f60d9 <String[50]: var SerialPort = require%28"serialport"%29.SerialPort;)
37: _line [readline.js:561] [pc=0x3a0d76b8eec3](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#)
38: _ttyWrite [readline.js:838] [pc=0x3a0d76b88082](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,s=0x3e0a9ad45c89 <String[1]: r>,key=0x274bed0f6c31 <an Object with map 0x234ea462a901>#20#)
39: onkeypress [readline.js:114] [pc=0x3a0d76b86619](this=0x274bed0acc61 <a ReadStream with map 0x234ea462a749>#21#,s=0x3e0a9ad45c89 <String[1]: r>,key=0x274bed0f6c31 <an Object with map 0x234ea462a901>#20#)
40: emitTwo(aka emitTwo) [events.js:106] [pc=0x3a0d76b23213](this=0x9bf71a04189 ,handler=0x274bed0b5d41 <JS Function onkeypress %28SharedFunctionInfo 0x3e0a9ad95541%29>#22#,isFn=0x9bf71a04231 ,self=0x274bed0acc61 <a ReadStream with map 0x234ea462a749>#21#,arg1=0x3e0a9ad45c89 <String[1]: r>,arg2=0x274bed0f6c31 <an Object with map 0x234ea462a901>#20#)
41: emit [events.js:191] [pc=0x3a0d76b22c62](this=0x274bed0acc61 <a ReadStream with map 0x234ea462a749>#21#,type=0x3e0a9ad45889 <String[8]: keypress)
42: arguments adaptor frame: 3->1
43: emitKeys(aka emitKeys) [internal/readline.js:384] [pc=0x3a0d76b653b0](this=0x9bf71a04189 ,stream=0x9bf71a041e9 <the hole)
44: next [native generator.js:21] [pc=0x3a0d76b65daa](this=0x274bed0b9219 #23#,i=0x3e0a9ad45c89 <String[1]: r)
45: onData [readline.js:930] [pc=0x3a0d76b84619](this=0x274bed0acc61 <a ReadStream with map 0x234ea462a749>#21#,b=0x274bed0f6b39 <an Uint8Array with map 0x234ea4605441>#24#)
46: emitOne(aka emitOne) [events.js:96] [pc=0x3a0d76b84070](this=0x9bf71a04189 ,handler=0x274bed0b67e9 <JS Function onData %28SharedFunctionInfo 0x3e0a9ad96469%29>#25#,isFn=0x9bf71a04231 ,self=0x274bed0acc61 <a ReadStream with map 0x234ea462a749>#21#,arg1=0x274bed0f6b39 <an Uint8Array with map 0x234ea4605441>#24#)
47: emit [events.js:188] [pc=0x3a0d76b22bea](this=0x274bed0acc61 <a ReadStream with map 0x234ea462a749>#21#,type=0x9bf71ad79c9 <String[4]: data)
48: arguments adaptor frame: 2->1
49: readableAddChunk(aka readableAddChunk) [_stream_readable.js:172] [pc=0x3a0d76b83a6c](this=0x9bf71a04189 ,stream=0x274bed0acc61 <a ReadStream with map 0x234ea462a749>#21#,state=0x274bed0ad539 <a ReadableState with map 0x234ea4620351>#26#,chunk=0x274bed0f6b39 <an Uint8Array with map 0x234ea4605441>#24#,encoding=0x9bf71a04189 ,addToFront=0x9bf71a04299 <false)
50: push [_stream_readable.js:130] [pc=0x3a0d76b83359](this=0x274bed0acc61 <a ReadStream with map 0x234ea462a749>#21#,chunk=0x274bed0f6b39 <an Uint8Array with map 0x234ea4605441>#24#,encoding=0x9bf71a04189 <undefined)
51: arguments adaptor frame: 1->2
52: onread [net.js:535] [pc=0x3a0d76b828b5](this=0x274bed0aceb9 <a TTY with map 0x234ea4626d89>#27#,nread=1,buffer=0x274bed0f6b39 <an Uint8Array with map 0x234ea4605441>#24#)
53: arguments adaptor frame: 3->2

==== C stack trace ===============================

1: v8::Template::Set(v8::Localv8::Name, v8::Localv8::Data, v8::PropertyAttribute)
2: SerialportPoller::Init(v8::Localv8::Object)
3: init
4: node::DLOpen(v8::FunctionCallbackInfov8::Value const&)
5: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfov8::Value const&))
6: 0x98b90b
7: 0x98beb1
8: 0x3a0d76a0961b
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

==== JS stack trace =========================================

Security context: 0x9bf71ac9fa9 #0#
1: .node [module.js:568] [pc=0x3a0d76bb6b04](this=0x274bed09fa39 <an Object with map 0x234ea4623371>#1#,module=0x274bed1720c9 <a Module with map 0x234ea4627361>#2#,filename=0x274bed171e61 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
2: load [module.js:456] [pc=0x3a0d76b99f72](this=0x274bed1720c9 <a Module with map 0x234ea4627361>#2#,filename=0x274bed171e61 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
3: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x3a0d76b99a9d](this=0x9bf71a04189 ,module=0x274bed1720c9 <a Module with map 0x234ea4627361>#2#,filename=0x274bed171e61 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
4: _load [module.js:407] [pc=0x3a0d76b96422](this=0x274bed09f541 <JS Function Module %28SharedFunctionInfo 0x3e0a9ad82639%29>#3#,request=0x274bed171241 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node>,parent=0x274bed163501 <a Module with map 0x234ea4627361>#4#,isMain=0x9bf71a04299 <false)
5: require [module.js:466] [pc=0x3a0d76b95e53](this=0x274bed163501 <a Module with map 0x234ea4627361>#4#,path=0x274bed171241 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
6: require(aka require) [internal/module.js:20] [pc=0x3a0d76b95b86](this=0x9bf71a04189 ,path=0x274bed171241 <String[69]: /tmp/serialtest/node_modules/serialport/build/Release/serialport.node)
7: bindings [/tmp/serialtest/node_modules/bindings/bindings.js:76] [pc=0x3a0d76bb27b6](this=0x9bf71ae8be9 #5#,opts=0x3e0a9add9201 <String[15]: serialport.node)
8: /* anonymous _/ [/tmp/serialtest/node_modules/serialport/lib/bindings.js:3] [pc=0x3a0d76bb114e](this=0x274bed15d421 <an Object with map 0x1dc73e207bc9>#6#,exports=0x274bed15d421 <an Object with map 0x1dc73e207bc9>#6#,require=0x274bed15e9f1 <JS Function require %28SharedFunctionInfo 0x3e0a9ad93441%29>#7#,module=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,__filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js>,__dirname=0x274bed15e989 <String[43]: /tmp/serialtest/node_modules/serialport/lib)
9: _compile [module.js:541] [pc=0x3a0d76b9e504](this=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,content=0x274bed15e009 <String[784]:)('serialport.node');\nvar listUnix = require('./list-unix');\n\nvar linux = process.platform !== 'win32' && process.platform !== 'darwin';\n\nfunction listLinux(callback) {\n callback = callback || function(err) {\n if (err) { this.emit('error', err) }\n }.bind(this);\n return listUnix(callback);\n};\n\nvar platformOptions = {};\nif (process.platform !== 'win32') {\n platformOptions = {\n vmin: 1,\n vtime: 0\n };\n}\n\nmodule.exports = {\n close: bindings.close,\n drain: bindings.drain,\n flush: bindings.flush,\n list: linux ? listLinux : bindings.list,\n open: bindings.open,\n SerialportPoller: bindings.SerialportPoller,\n set: bindings.set,\n update: bindings.update,\n write: bindings.write,\n platformOptions: platformOptions\n};\n>,filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js>)
10: .js [module.js:550] [pc=0x3a0d76b9ac8b](this=0x274bed09fa39 <an Object with map 0x234ea4623371>#1#,module=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js)
11: load [module.js:456] [pc=0x3a0d76b99f72](this=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js)
12: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x3a0d76b99a9d](this=0x9bf71a04189 ,module=0x274bed15d3d1 <a Module with map 0x234ea4627361>#8#,filename=0x274bed15d311 <String[55]: /tmp/serialtest/node_modules/serialport/lib/bindings.js)
13: load [module.js:407] [pc=0x3a0d76b96422](this=0x274bed09f541 <JS Function Module %28SharedFunctionInfo 0x3e0a9ad82639%29>#3#,request=0x3e0a9adc0799 <String[10]: ./bindings>,parent=0x274bed104101 <a Module with map 0x234ea4627361>#9#,isMain=0x9bf71a04299 <false)
14: require [module.js:466] [pc=0x3a0d76b95e53](this=0x274bed104101 <a Module with map 0x234ea4627361>#9#,path=0x3e0a9adc0799 <String[10]: ./bindings)
15: require(aka require) [internal/module.js:20] [pc=0x3a0d76b95b86](this=0x9bf71a04189 ,path=0x3e0a9adc0799 <String[10]: ./bindings)
16: /
anonymous _/ [/tmp/serialtest/node_modules/serialport/lib/serialport.js:16] [pc=0x3a0d76b9ebee](this=0x274bed104189 <an Object with map 0x1dc73e207bc9>#10#,exports=0x274bed104189 <an Object with map 0x1dc73e207bc9>#10#,require=0x274bed10c411 <JS Function require %28SharedFunctionInfo 0x3e0a9ad93441%29>#11#,module=0x274bed104101 <a Module with map 0x234ea4627361>#9#,__filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js>,__dirname=0x274bed10c3a9 <String[43]: /tmp/serialtest/node_modules/serialport/lib)
17: _compile [module.js:541] [pc=0x3a0d76b9e504](this=0x274bed104101 <a Module with map 0x234ea4627361>#9#,content=0x274bed104f79 <Very long string[13443]>#12#,filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js)
18: .js [module.js:550] [pc=0x3a0d76b9ac8b](this=0x274bed09fa39 <an Object with map 0x234ea4623371>#1#,module=0x274bed104101 <a Module with map 0x234ea4627361>#9#,filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js)
19: load [module.js:456] [pc=0x3a0d76b99f72](this=0x274bed104101 <a Module with map 0x234ea4627361>#9#,filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js)
20: tryModuleLoad(aka tryModuleLoad) [module.js:415] [pc=0x3a0d76b99a9d](this=0x9bf71a04189 ,module=0x274bed104101 <a Module with map 0x234ea4627361>#9#,filename=0x274bed0fff71 <String[57]: /tmp/serialtest/node_modules/serialport/lib/serialport.js)
21: load [module.js:407] [pc=0x3a0d76b96422](this=0x274bed09f541 <JS Function Module %28SharedFunctionInfo 0x3e0a9ad82639%29>#3#,request=0x3e0a9adb9389 <String[10]: serialport>,parent=0x274bed0afd79 <a Module with map 0x234ea4627361>#13#,isMain=0x9bf71a04299 <false)
22: require [module.js:466] [pc=0x3a0d76b95e53](this=0x274bed0afd79 <a Module with map 0x234ea4627361>#13#,path=0x3e0a9adb9389 <String[10]: serialport)
23: require(aka require) [internal/module.js:20] [pc=0x3a0d76b95b86](this=0x9bf71a04189 ,path=0x3e0a9adb9389 <String[10]: serialport)
24: /
anonymous _/ [repl:1] [pc=0x3a0d76b94cf6](this=0x9bf71ae8be9 #5#)
28: defaultEval [repl.js:272] [pc=0x3a0d76b94200](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,code=0x274bed0f7fc9 <String[51]: var SerialPort = require%28"serialport"%29.SerialPort;n>,context=0x9bf71ae8be9 #5#,file=0x9bf71ad7891 <String[4]: repl>,cb=0x274bed0f73a1 <JS Function finish %28SharedFunctionInfo 0x3e0a9adb6fc9%29>#15#)
29: bound(aka bound) [domain.js:280] [pc=0x3a0d76b92f2e](this=0x9bf71a04189 ,this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,self=0x274bed0ab979 <a Domain with map 0x234ea4625fc9>#16#,cb=0x274bed0ab891 <JS Function defaultEval %28SharedFunctionInfo 0x3e0a9ad8db71%29>#17#,fnargs=0x274bed0f8021 <an Arguments with map 0x1dc73e20a509>#18#)
30: eval(aka runBound) [domain.js:293] [pc=0x3a0d76b92d32](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#)
31: arguments adaptor frame: 4->0
32: /
anonymous */ [repl.js:441] [pc=0x3a0d76b9061e](this=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,cmd=0x274bed0f60d9 <String[50]: var SerialPort = require%28"serialport"%29.SerialPort;)
33: emitOne(aka emitOne) [events.js:101] [pc=0x3a0d76b84139](this=0x9bf71a04189 ,handler=0x274bed0cee91 <JS Array[2]>#19#,isFn=0x9bf71a04299 ,self=0x274bed0ab7d9 <an REPLServer with map 0x234ea4629511>#14#,arg1=0x274bed0f60d9 <String[50]: var SerialPort = require%28"serialport"%29.SerialPort;)undefined

@ericogr ericogr changed the title Node.js v6.0.0 - Runtime error Node.js v6.0.0 - library loading crash Apr 30, 2016
@fivdi
Copy link
Contributor

fivdi commented Apr 30, 2016

This isn't actually a crash, it's a dramatically formatted message indicating that there will be a change in V8 at some point in the future:

(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

The message can be ignored and everything should function as expected. The message will no longer appear when serialport is upgraded to nan v2.3.2.

@ericogr
Copy link
Author

ericogr commented Apr 30, 2016

Yes, thats true. I'll change the title.

@ericogr ericogr changed the title Node.js v6.0.0 - library loading crash Node.js v6.0.0 - deprecated message Apr 30, 2016
@reconbot reconbot changed the title Node.js v6.0.0 - deprecated message Node.js v6.0.0 - upgrade nan May 1, 2016
@reconbot reconbot mentioned this issue May 1, 2016
@reconbot
Copy link
Member

reconbot commented May 1, 2016

Some of these things are errors in the latest nan with node 6. So we can't upgrade it yet.

@fivdi
Copy link
Contributor

fivdi commented May 1, 2016

There's more to this than I initially assumed. nodejs/nan#560 which was released with nan@2.3.2 modified Nan::SetPrototypeMethod to solve one cause of the deprecation message issue. However, the deprecation messages in serialport are being caused by Nan::SetPrototypeTemplate here. As can be seen in nodejs/nan#565, Nan::SetPrototypeTemplate will not be modified.

If serialport uses Nan::SetPrototypeMethod rather than Nan::SetPrototypeTemplate the deprecation message should no longer appear.

@reconbot
Copy link
Member

reconbot commented May 1, 2016

merged the latest nan with @fivdi's cleanup in #778

We were getting inconsistent failures with node6 on osx so I added it to the "allowed failures" until it's clear this patch fixed that or we figure out that issue.

@reconbot reconbot closed this as completed May 1, 2016
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants