Merge pull request #16 from nblumhardt/fix-readshare

Make shared log files readable while in use

Author: nblumhardt

src/Serilog.Sinks.File/Sinks/File/FileSink.cs

@@ -14,9 +14,6 @@
 
 using System;
 using System.IO;
-#if ATOMIC_APPEND
-using System.Security.AccessControl;
-#endif
 using System.Text;
 using Serilog.Core;
 using Serilog.Events;
@@ -64,13 +61,7 @@ public FileSink(string path, ITextFormatter textFormatter, long? fileSizeLimitBy
                 Directory.CreateDirectory(directory);
             }
 
-#if ATOMIC_APPEND
-            // FileSystemRights.AppendData improves performance substantially (~30%) when available.
-            Stream file = new FileStream(path, FileMode.Append, FileSystemRights.AppendData, FileShare.Read, 4096, FileOptions.None);
-#else
             Stream file = System.IO.File.Open(path, FileMode.Append, FileAccess.Write, FileShare.Read);
-#endif
-
             if (_fileSizeLimitBytes != null)
             {
                 file = _countingStreamWrapper = new WriteCountingStream(file);

src/Serilog.Sinks.File/Sinks/File/SharedFileSink.cs

@@ -75,7 +75,7 @@ public SharedFileSink(string path, ITextFormatter textFormatter, long? fileSizeL
                 path, 
                 FileMode.Append,
                 FileSystemRights.AppendData,
-                FileShare.Write,
+                FileShare.ReadWrite,
                 _fileStreamBufferLength,
                 FileOptions.None);
 
@@ -118,7 +118,7 @@ public void Emit(LogEvent logEvent)
                             _path,
                             FileMode.Append,
                             FileSystemRights.AppendData,
-                            FileShare.Write,
+                            FileShare.ReadWrite,
                             length,
                             FileOptions.None);
                         _fileStreamBufferLength = length;