Add await to deterministically finish registering with fastify #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you run |
dsschneidermann
force-pushed
the
master
branch
from
cd3d964
to
64ee96e
Compare
Done so. It also auto-updated the example project dependency, so I kept it as a separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #627
Impact to users should be negligeble. If they weren't awaiting their own
fastify.registercall, then there is no behavior difference. If they are awaiting theirfastify.registercall, they were probably expecting the routes to be loaded and ready right after.Alternative solution, branch the code and only perform the await based on some new opt-in option.
Should I look at impact to this projects tests?