Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity.add...Revision #400

Closed
Tracked by #1590
CarolinJaser opened this issue Jun 9, 2021 · 3 comments · Fixed by #525
Closed
Tracked by #1590

Entity.add...Revision #400

CarolinJaser opened this issue Jun 9, 2021 · 3 comments · Fixed by #525
Labels
enhancement New feature or request
Milestone

Comments

@CarolinJaser
Copy link
Member

Mutation to replace legacy mutation which is doing the same thing. It should include:

changes
content
shouldReview
subscriptionSetEmail
subscriptionNotify (or a better name)
entityId
metaDescription
metaTitle
title

@kulla kulla added the enhancement New feature or request label Jun 9, 2021
@kulla kulla added this to the Frontend 100% milestone Jun 9, 2021
@hugotiburtino hugotiburtino linked a pull request Feb 15, 2022 that will close this issue
@hugotiburtino
Copy link
Member

hugotiburtino commented Feb 16, 2022

Since the revisions can have different fields (v.g. article has title, content, meta_title, meta_description, while course page has only title, content), the suggested mutation has to be splitted into many in order to have something similar to type check of the payload. In that case, we will have something like AddArticleRevisionMutation and AddCoursePageRevisionMutation

@elbotho
Copy link
Member

elbotho commented Feb 16, 2022

Could the mutation accept a union type?

edit: not really it seems -.-

@hugotiburtino
Copy link
Member

hugotiburtino commented Feb 18, 2022

Could the mutation accept a union type?
edit: not really it seems -.-

No, it doesn't. Also not interface. It is quite frustating.

But anyways, instead of many mutations, I thought it would be tidier to put them all in the EntityMutation namespace. So, we will have EntityMutation.addCoursePageRevision, EntityMutation.addArticleRevision and so on.

@hugotiburtino hugotiburtino moved this from To-Do to In Progress in Migrate legacy serlo.org Feb 21, 2022
@hugotiburtino hugotiburtino changed the title addRevision() Mutation Entity.addRevision(s) Mutation Mar 1, 2022
@hugotiburtino hugotiburtino changed the title Entity.addRevision(s) Mutation Entity.addRevision(s) Mar 1, 2022
@hugotiburtino hugotiburtino changed the title Entity.addRevision(s) Entity(ies).addRevision Mar 1, 2022
@hugotiburtino hugotiburtino changed the title Entity(ies).addRevision Entity.add...Revision Mar 16, 2022
@hugotiburtino hugotiburtino moved this from In Progress to In Staging in Migrate legacy serlo.org Mar 22, 2022
@hugotiburtino hugotiburtino moved this from In Staging to In Special Url in Migrate legacy serlo.org Mar 24, 2022
@hugotiburtino hugotiburtino moved this from In Special Url to In Staging in Migrate legacy serlo.org Apr 11, 2022
@kulla kulla moved this from Deployed in Staging to Deployed in Production in Migrate legacy serlo.org Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Deployed in Production
Development

Successfully merging a pull request may close this issue.

4 participants