feat: allow constructable modules #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Murtatrxx
added
meta: Enhancement
Murtatrxx
approved these changes
Sep 11, 2022
Murtatrxx
added
effort: 1
Murtatrxx
added a commit
that referenced
this pull request
Sep 13, 2022
This reverts commit 03936eb.
jacoobes
pushed a commit
that referenced
this pull request
Sep 13, 2022
jacoobes
added a commit
that referenced
this pull request
Oct 4, 2022
* Update readFile.ts * Update userDefinedEventsHandling.ts * Update readyHandler.ts * fix: ts error Co-authored-by: Jacob Nguyen <76754747+jacoobes@users.noreply.github.com> Co-authored-by: xxDeveloper <77380166+Murtatrxx@users.noreply.github.com>
jacoobes
pushed a commit
that referenced
this pull request
Oct 4, 2022
jacoobes
added a commit
that referenced
this pull request
Dec 28, 2022
* style: prettier line feed changes * style: prettier line feed changes * feat: prototyping module manager * feat: removing unused types * feat: update location of module typings * revert: port back to original interaction type checkers * revert: port back to original interaction type checkers * revert: remove unneeded type predicates * feat: moving modules to its own contained class * feat: getting global plugins some typings and adding contracts * chore: fixing up and cleaning code * feat: adding ModuleConfiguration helper fn and default module manager * feat: solidifying contract * revert: delete files * chore: saving for later * feat: prototyping module manager * feat: removing unused types * feat: update location of module typings * revert: port back to original interaction type checkers * revert: port back to original interaction type checkers * revert: remove unneeded type predicates * feat: moving modules to its own contained class * feat: getting global plugins some typings and adding contracts * chore: fixing up and cleaning code * feat: adding ModuleConfiguration helper fn and default module manager * feat: solidifying contract * revert: delete files * chore: saving for later * feat: more merge conflicts * feat: starting from scratch, add new typings * feat: refactor ScopedPlugin typing * feat: strengthening contracts * chore: edit eslint * feat: add addDependencies * feat: add iti di * feat: constfn util * revert: delete old files * remove: ModuleConfiguration * feat: add sanity checker * feat: add new error and update dependency * feat: add sanity check for iti * feat: add function helpers for di * feat: add POC for sern di IOC * feat: refactor DependenciesMap * revert: remove old code * feat: refactor makeDependencies fn * chore(deps): update dependency @typescript-eslint/parser to v5.36.1 (#127) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @typescript-eslint/eslint-plugin to v5.36.1 (#126) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs: Fix the code example (#128) * chore(deps): update dependency @typescript-eslint/eslint-plugin to v5.36.2 (#130) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: xxDeveloper <77380166+Murtatrxx@users.noreply.github.com> * chore(deps): update dependency @typescript-eslint/parser to v5.36.2 (#131) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: xxDeveloper <77380166+Murtatrxx@users.noreply.github.com> * feat: allow constructable modules (#133) * Update readFile.ts * Update userDefinedEventsHandling.ts * Update readyHandler.ts * fix: ts error Co-authored-by: Jacob Nguyen <76754747+jacoobes@users.noreply.github.com> Co-authored-by: xxDeveloper <77380166+Murtatrxx@users.noreply.github.com> * revert: feat of allow constructable modules (#138) Revert "feat: allow constructable modules (#133)" This reverts commit 03936eb. * feat: update CODEOWNERS * feat: classmodules@arcs (#143) * feat: add class based commands * docs: add deprecation warnings * feat: add deprecation warnings * feat: add more deprecation warnings * feat: add prototype ClassModule abstract class * feat: add EventModuleClass prototype, change names * feat: more flexible contract * feat: EventExecutable * fix: typo * feat: made abstract classes because of defaults * fix: typings * feat: update Context typings, update to djs v15 * chore: update typescript dependency * chore: bump version * chore: update ignore * chore: prettier * docs: change readme to be docusaurus compliant * chore(main): release 1.2.0 (#145) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(autocomplete): now support multiple autocomplete options (#147) * chore(main): release 1.2.1 (#148) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: update location of module typings * feat: getting global plugins some typings and adding contracts * feat: adding ModuleConfiguration helper fn and default module manager * feat: solidifying contract * feat: removing unused types * feat: update location of module typings * feat: moving modules to its own contained class * feat: getting global plugins some typings and adding contracts * feat: solidifying contract * revert: delete files * chore: saving for later * feat: more merge conflicts * feat: starting from scratch, add new typings * feat: strengthening contracts * feat: add sanity check for iti * feat: refactor DependenciesMap * feat: adding POC back * docs: add some deprecation warnings * feat: remove client and sernEmitter * feat: rebase global_services * chore: oops rebase pkgjson fix * fix: typings * feat: iti update and getting di working * feat: adding contracts and default provider * feat: update typings and change logger * fix: MapDeps typings and useContainer typings * feat: moving handlers to 2.0 * feat: injecting crash handler * feat: alpha logging injection? * feat: injecting modulemanager in interactionhandler * fix: typos and fixups * fix: typos and fixups * feat: moduleManager injection * fix: crash on no module * feat: i think optional dependencies work * feat: add more optional support * feat: make exclusion optional * perf: simplify typings and reduce compile time * fix: some typings adjustment, deprecating a field * perf: simplifying plugin typings * feat: remove addExternal * feat: more simplifying typings * perf: allow any and interfacify some types * revert: remove horrendous Override type * revert: delete interaction type predicates * fix: unchecked cast to EventEmitter * perf: remove unneeded creation of instance members * feat: init test dir * refactor: rename fn and short circuit name fn * refactor: insert function * feat: starting event module onEvent plugins and log payload * feat: basic eventmodule event plugins? * refactor: DRY * feat: unify warning typing * fix: typings * feat: more progress on new eventModules * feat: event modules with plugins!!?!? * feat: making sernEmitter create default!!, readjust typings * feat: inject sernEmitter emits and catch possible errors * feat: add optionality to Logger dep type * feat: context upgrade, fix circular emissions, crap ton of shit * feat!: Module -> AnyModule, Added new SelectMenuInteractions, Changed some CommandType names * feat: rudimentary onClick handler * feat!: rename select menu command types, no distinguishing between text and alias * docs: adding docs * fix: forgot to change * fix: logging undefined * revert: remove spreadparams * feat: export useContainerRaw function and fix smol bug * feat: add iti DI disposeAll on crash * fix: deferred execute * feat!: rename BasePlugin -> Plugin * feat: commandplugins for event modules, ill test later * refactor: rename * refactor: remove import * feat: add deprecation warnings * feat: update documentation comments * perf: static'ify command plugin and event plugin typings * refactor: remove redundant assignment * feat: switch to pnpm * chore: update pnpm lock * fix: errors crashing and completing subscription * feat: update example * fix: overriding dependencies no matter what * fix: bad rxjs docs * refactor: destructuring * feat: update typings for addDisposer * feat: update packageManager field in package.json * feat: grammar Co-authored-by: jacoobes <jacobnguyend@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: xxDeveloper <77380166+Murtatrxx@users.noreply.github.com> Co-authored-by: Arcs <73959934+HighArcs@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Evo <85353424+EvolutionX-10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow class based modules lol