Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!:(2.0 global services) #156

Merged
merged 151 commits into from
Dec 28, 2022
Merged

feat!:(2.0 global services) #156

merged 151 commits into from
Dec 28, 2022

Conversation

jacoobes
Copy link
Member

@jacoobes jacoobes commented Nov 3, 2022 •
edited by EvolutionX-10
Loading

sern 2.0!!!

  • Test it at your own risk, this PR is in active development. If you decide to test and find some bugs, make sure to report it in our server

INCLUDES BREAKING CHANGES!

jacoobes added 30 commits August 19, 2022 01:24
@jacoobes
style: prettier line feed changes
4323be4
@jacoobes
style: prettier line feed changes
74e004d
@jacoobes
feat: prototyping module manager
8626add
@jacoobes
feat: removing unused types
2b6335f
@jacoobes
feat: update location of module typings
7162ccb
@jacoobes
revert: port back to original interaction type checkers
b94a9e9
@jacoobes
revert: port back to original interaction type checkers
6565697
@jacoobes
revert: remove unneeded type predicates
c98425d
@jacoobes
feat: moving modules to its own contained class
4092b9b
@jacoobes
feat: getting global plugins some typings and adding contracts
2830370
@jacoobes
chore: fixing up and cleaning code
8c6fb27
@jacoobes
feat: adding ModuleConfiguration helper fn and default module manager
3c0da26
@jacoobes
feat: solidifying contract
a4301dc
@jacoobes
revert: delete files
e85eb81
@jacoobes
chore: saving for later
0c2f1b5
@jacoobes
feat: prototyping module manager
813ba09
@jacoobes
feat: removing unused types
fd9dc35
@jacoobes
feat: update location of module typings
b0e5512
@jacoobes
revert: port back to original interaction type checkers
23edd5b
@jacoobes
revert: port back to original interaction type checkers
3b0b94b
@jacoobes
revert: remove unneeded type predicates
a0ab415
@jacoobes
feat: moving modules to its own contained class
2f10b0e
@jacoobes
feat: getting global plugins some typings and adding contracts
651f4aa
@jacoobes
chore: fixing up and cleaning code
9b51fc0
@jacoobes
feat: adding ModuleConfiguration helper fn and default module manager
f993e3f
@jacoobes
feat: solidifying contract
e2471d3
@jacoobes
revert: delete files
a40c7ef
@jacoobes
chore: saving for later
8c12576
@jacoobes
Merge remote-tracking branch 'origin/feat_of_module-manager' into fea…
3f6ce51 
…t_of_module-manager

# Conflicts:
#	package-lock.json
#	package.json
#	src/handler/events/observableHandling.ts
#	src/types/handler.ts
@jacoobes
feat: more merge conflicts
aca8ae2
@jacoobes jacoobes marked this pull request as ready for review December 15, 2022 16:36
@jacoobes
refactor: remove redundant assignment
f0d8075
@jacoobes
feat: switch to pnpm
be47924
@jacoobes
Merge remote-tracking branch 'origin/main' into global_services
6df8bc6 
# Conflicts:
#	README.md
#	package-lock.json
#	package.json
#	src/handler/sern.ts
#	src/handler/structures/context.ts
#	src/handler/structures/wrapper.ts
#	src/handler/utilities/treeSearch.ts
#	src/types/handler.ts
@jacoobes
chore: update pnpm lock
1b04cae
@jacoobes
fix: errors crashing and completing subscription
2abcbe6
@EvolutionX-10
Copy link
Member

review is in progress, will do it some files at a time 😅

EvolutionX-10
EvolutionX-10 approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@EvolutionX-10 EvolutionX-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why test/esm/src/index.ts is empty file?

.eslintrc Show resolved Hide resolved
src/handler/events/messageHandler.ts Show resolved Hide resolved
src/handler/structures/enums.ts Show resolved Hide resolved
src/handler/utilities/functions.ts Show resolved Hide resolved
@jacoobes
Copy link
Member Author

Was gonna add testing but I'm lazy

Murtatrxx
Murtatrxx reviewed Dec 26, 2022
View reviewed changes
Copy link
Member

@Murtatrxx Murtatrxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but needs small improvements

src/handler/dependencies/provider.ts Show resolved Hide resolved
src/handler/structures/errors.ts Outdated Show resolved Hide resolved
@jacoobes jacoobes merged commit 1455622 into main Dec 28, 2022
@github-actions github-actions bot mentioned this pull request Dec 28, 2022
Merged
@jacoobes jacoobes deleted the global_services branch December 28, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murtatrxx Murtatrxx Murtatrxx left review comments

@EvolutionX-10 EvolutionX-10 EvolutionX-10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacoobes @EvolutionX-10 @Murtatrxx @trueharuu