Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dispose hooks (deprecate useContainerRaw) #323

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Conversation

jacoobes
Copy link
Member

@jacoobes jacoobes commented Aug 17, 2023

Description, this has a few changes

  • inversion of control for adding disposers. This refactors the hook logic and extracts it to separate namespace
  • Adds dispose hook. Dependencies simply need to implement Disposable to add extra logic.
  • deprecates useContainerRaw because it bleeds too much internals. Service takes over its role
  • un minifies content (no need to minify until actual bot is being made for production)
  • fixes regression with context (i unwrap incorrectly)

@jacoobes jacoobes marked this pull request as ready for review August 17, 2023 16:55
@jacoobes jacoobes requested a review from Murtatrxx August 17, 2023 16:59
package.json Show resolved Hide resolved
tsup.config.js Show resolved Hide resolved
@jacoobes jacoobes merged commit 26ccd11 into main Aug 17, 2023
@jacoobes jacoobes deleted the feat/dispose-hooks branch September 8, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants