Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sern emitter err #358

Merged
merged 3 commits into from
Mar 18, 2024
Merged

fix: sern emitter err #358

merged 3 commits into from
Mar 18, 2024

Conversation

jacoobes
Copy link
Member

@jacoobes jacoobes commented Mar 16, 2024

sern/emitter never emits an error event when it occurs for command module handling. Must have been a regression i overlooked while i was refactoring
This patches that and improves the typings for it

@jacoobes jacoobes requested a review from SrIzan10 March 18, 2024 06:25
Copy link
Member

@SrIzan10 SrIzan10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah that was unexpected... LGTM!

@SrIzan10
Copy link
Member

SrIzan10 commented Mar 18, 2024

redeploy automata before releasing

@jacoobes jacoobes merged commit 90e55df into main Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants