Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shrink package size, improve dev deps, esm and cjs support #98

Merged
merged 38 commits into from
Aug 6, 2022
Merged

feat: shrink package size, improve dev deps, esm and cjs support #98

merged 38 commits into from
Aug 6, 2022

Conversation

jacoobes
Copy link
Member

@jacoobes jacoobes commented Aug 5, 2022 •
edited
Loading

This merge

  • esm and cjs support
  • better development experience
    • uses tsup for faster build times
    • scripts directory
    • more automation
  • shrink install size ( -8 Mbs ) !
  • improves comments

jacoobes added 26 commits July 18, 2022 12:14
@jacoobes
chore: fix tsc predicate type checking
018f184
@jacoobes
build: add tsup as bundler
97d6591
@jacoobes
chore: revert text
ce0644d
@jacoobes
chore: fix predicates.ts, update dependencies, bump version
2f07f45
@jacoobes
docs: update example
ca37158
@jacoobes
build: update dependencies
d18eaa9
@jacoobes
fix: crash on collectors (#89)
d8051e2 
* fix: crash on collectors

* feat: bump version for bug fix
@jacoobes
fix: crash on collectors pt
07482e9
@jacoobes
docs: adding some documentation for docasaurus
8cf0fe0
@jacoobes
docs: add errors.ts comments
6a47abb
@jacoobes
docs: refactor comments
1e462d9
@jacoobes
docs: adding examples
c0958c6
@jacoobes
feat: refresh package-lock.json
d8eaac7
@jacoobes
refactor: destructure and clean namespaces
84cae8c
@jacoobes
feat: add regen package.json script
6c287a6
@jacoobes
feat: add tsup, remove tsc, add scripts
11b814e
@jacoobes
feat: update ts-results import style
1abe9ce
@jacoobes
feat: readd typescript because idk if i should
5c2cedc
@jacoobes
feat: breakup tsconfigs and add tsup config
8e82605
@jacoobes
feat: add esm json tsconfig to git
d9f9b87
@jacoobes
build: update dependencies and move to ts-result-es
78a17f4
@jacoobes
feat: remove unused function
c6c49df
@jacoobes
feat: update ts-results for esm/cjs interop!
5ef1f4d
@jacoobes
revert: remove version.txt
bb5a0eb
@jacoobes
build: goodbye tsc, hello tsup
016b661
@jacoobes
build: moving discord.js as dev dependency
334147c
@jacoobes
Copy link
Member Author

jacoobes commented Aug 5, 2022

This will be the final branch until version 1.0.0

EvolutionX-10
EvolutionX-10 approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@EvolutionX-10 EvolutionX-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG you did it! cheers
Have a look at comment

package.json Show resolved Hide resolved
src/handler/structures/errors.ts Outdated Show resolved Hide resolved
Murtatrxx
Murtatrxx approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@Murtatrxx Murtatrxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at all, needs small improvements.

package.json Show resolved Hide resolved
scripts/mkjson.mjs Outdated Show resolved Hide resolved
src/handler/events/observableHandling.ts Show resolved Hide resolved
src/handler/plugins/plugin.ts Show resolved Hide resolved
src/handler/sern.ts Show resolved Hide resolved
src/handler/structures/enums.ts Show resolved Hide resolved
src/handler/structures/wrapper.ts Outdated Show resolved Hide resolved
Murtatrxx
Murtatrxx requested changes Aug 6, 2022
View reviewed changes
Copy link
Member

@Murtatrxx Murtatrxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one thing left, and then it's good to go so far 😃

.npmignore Show resolved Hide resolved
@EvolutionX-10 EvolutionX-10 requested a review from Murtatrxx August 6, 2022 17:15
@Murtatrxx Murtatrxx enabled auto-merge (squash) August 6, 2022 17:16
@Murtatrxx Murtatrxx disabled auto-merge August 6, 2022 17:19
@jacoobes jacoobes merged commit 74378f0 into main Aug 6, 2022
@jacoobes
Copy link
Member Author

jacoobes commented Aug 6, 2022

cheers

@Murtatrxx Murtatrxx deleted the shrinkpatability branch August 6, 2022 20:51
@github-actions github-actions bot mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvolutionX-10 EvolutionX-10 EvolutionX-10 approved these changes

@Murtatrxx Murtatrxx Murtatrxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacoobes @Murtatrxx @EvolutionX-10