Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google Shopping API] Almost empty results #2155

Open
hilmanski opened this issue Nov 20, 2024 · 5 comments
Open

[Google Shopping API] Almost empty results #2155

hilmanski opened this issue Nov 20, 2024 · 5 comments
Assignees
Labels
status: queued Ready to work on type: bug Something is broken

Comments

@hilmanski
Copy link

hilmanski commented Nov 20, 2024

A customer reported that a search on Google Shopping returned basically empty results. It only shows one sponsored result with no shopping_results.

CleanShot 2024-11-20 at 14 39 47

I suspect this is just a one-time issue since I can't replicate it on my side.

Notes:

  • The customer used num for this search, but I'm not sure if that's the cause.
  • The customer suspect that the cause is the missing domain, in this case: google.com.au

Internal links: Intercom | Search Inspect 1

@hilmanski hilmanski added status: queued Ready to work on type: bug Something is broken labels Nov 20, 2024
@alexbarron
Copy link

alexbarron commented Nov 20, 2024

Edit: Bumping to prioritized status as this is impacting a long-time customer's ability to demo their solution to clients.

The customer provided another example of the issue without setting a num param and including google_domain=google.com.au. However in this instance, inline_shopping_results appeared, but no shopping_results were returned despite the same query manually in Google returning normal shopping results. Inspect

image

Additionally I've been able to reproduce the issue; although responses vary in quality.

In one instance, I received only one sponsored result in the HTML preview, but empty JSON. This is the same as the customer's original report. Inspect

image

In another instance, I got nothing at all. Inspect

image

It's a small sample size, but most of the time this query seems to work. Unclear why it's so inconsistent. Here's what it looks like when it works:

image

@alexbarron alexbarron added status: prioritized Prioritized work and removed status: queued Ready to work on labels Nov 20, 2024
@dsojevic
Copy link

To add some minor context here; I ran a small test of 100 searches (using the same parameters used in the examples above) and found that 7/100 had an issue with Google returning a blank result area.

It appears that the HTML we are provided in those instances is fully devoid of any product information, so it might be that we need to do a transparent retry in these instances if we can find a suitable indicator versus a search with no actual results.

@marm123
Copy link

marm123 commented Dec 11, 2024

Another user reported this issue:

Intercom

I've recreated the issue for a valid search:
Inspect
image

Do we have an ETA for when this can be worked on and fixed?

@mikemorcerf
Copy link

@kagermanov27, do you think this could be related to this comment you posted in this PR?

According to @dsojevic's findings though it happens less than 10% of the times.

@dsojevic dsojevic self-assigned this Feb 7, 2025
@dsojevic
Copy link

dsojevic commented Feb 7, 2025

I've performed a large number of tests against the problematic searches that were originally reported, searches I had previously been able to reproduce the issue with, and a series of assorted novel searches and have been unable to reproduce it at this time.

As we haven't had any recently reported instances of this issue recurring, I'm going to leave this open for now and adjust the priority. If any new instances are reported or if anyone else is able to reliably reproduce the issue, I will re-raise the priority and address it promptly.

@dsojevic dsojevic added status: queued Ready to work on and removed status: prioritized Prioritized work labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: queued Ready to work on type: bug Something is broken
Projects
None yet
Development

No branches or pull requests

5 participants