Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a conflict type to stone #39

Closed
ikeycode opened this issue Sep 20, 2023 · 2 comments
Closed

Add a conflict type to stone #39

ikeycode opened this issue Sep 20, 2023 · 2 comments
Assignees
Labels
type: feature A new functionality to implement.

Comments

@ikeycode
Copy link
Member

Conflict will essentially be identical to Dependency/Provider, allowing us to conflict with a specific type of identity.

Sidequest:

  • Extend DAG/layering to handle conflict resolution
  • Perhaps a time to investigate eopkg-style replaces?
@GZGavinZhao
Copy link
Contributor

GZGavinZhao commented Nov 28, 2023

Working on autobuild right now but I want to come back to this at a later date, so writing in case I forget.

Detecting and outputting conflicts is a 2-SAT problem and can be done in O(N + M) time where N is the number of packages and M is the number of dependency relations. The only graph algorithm I need is the ability to form a strongly connected component, which petgraph does provide so I believe this is doable.

I haven't come up with a way to output the conflict between providers. In other words, in my current design, when a conflict happens, all I can do is to say hey surprise package X conflicts with packages Y, Z, ... I haven't figured out a way to say provider bin(X) conflicts with providers soname(liby) and name(Z).

This is not true, I over-complicated things. See #94 for details.

@ermo
Copy link
Member

ermo commented Sep 22, 2024

Added in #248

@ermo ermo closed this as completed Sep 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tooling & Infra (current scope) Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new functionality to implement.
Projects
Development

No branches or pull requests

4 participants