Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aliasStage (throttlingRateLimit, throttlingBurstLimit) setting has no effect #182

Open
AliasIO opened this issue Jan 23, 2020 · 1 comment

Comments

@AliasIO
Copy link

AliasIO commented Jan 23, 2020

I'm trying to configure throttlingRateLimit and throttlingBurstLimit for the API stage using the aliasStage setting but deploying just sets these values to the defaults (10,000 and 5,000).

...
plugins:
  - serverless-aws-alias

provider:
  ...
  aliasStage:
    throttlingBurstLimit: 10
    throttlingRateLimit: 5

functions:
  init:
    ...
    aliasStage:
      throttlingBurstLimit: 10
      throttlingRateLimit: 5

I tried to debug the issue myself, from what I can see the generated CloudFormation template does seem to be correct:

{
  "stageResource": {
      ...
      "MethodSettings": [
        {
          "ThrottlingBurstLimit": 10,
          "ThrottlingRateLimit": 5,
          "ResourcePath": "/~1",
          "HttpMethod": "GET"
        }
      ]
    },
    ...
  }
}

To work around this I need to remember to manually change the values after each deployment. I don't think I'm doing anything wrong here, is it working for anyone else?

$ sls --version
Framework Core: 1.61.3
Plugin: 3.2.7
SDK: 2.3.0
Components Core: 1.1.2
Components CLI: 1.4.0
{
  "devDependencies": {
    "serverless-aws-alias": "^1.8.0"
  }
}

cc @HyperBrain #59

@mike-suggitt
Copy link

+1 Same for me. Values seem to be ignored and limits remain untouched on API gateway.

If I set all the throttle values to 1 and then deploy using 75 the deploy seems to work fine without error but values remain at 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants